BUG: sparse: Use _ascontainer for argmin/argmax #18121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perimosocordiae
added
defect
tylerjereddy
added
the
backport-candidate
tylerjereddy
force-pushed
the
perimosocordiae-patch-8
branch
from
388d1f5
to
cf1c6f7
Compare
|
I rebased on latest |
|
I had to restart one job, but after that CI was all green. I squash-merged to make it easier to backport if we do another |
tylerjereddy
pushed a commit
to tylerjereddy/scipy
that referenced
this pull request
Apr 16, 2023
* BUG: sparse: Use _ascontainer for argmin/argmax * Adding test coverage * Remove unused import * skip sparse formats that don't support min/max
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes gh-18111
What does this implement/fix?
The current implementation of sparse arrays relies on the use of
_containerand_ascontainerclassmethods to dispatch to the correct output type when returning dense results. In this case, we'd overlooked a callsite that was unconditionally invokingnp.matrix.