New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: prepare for SciPy 1.10.0 "final" #17696
MAINT: prepare for SciPy 1.10.0 "final" #17696
Conversation
CI is all green with no skip directive active. There was a request to add a missing contributor (#14386 (comment)), so I'm now going to push in a commit that does that, but skips most of the CI outside of docs stuff. |
@rgommers I think this is probably ready to go--if you want me to proceed differently with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pybind11 version constraint looks good to me. I'd recommend squashing the first 3 commits in this PR. Should be good to go for 1.10.0 final, no need for RC3 I think.
* remove the pybind11 version exclusion from Windows Meson job in GitHub actions * pin pybind11 to version `2.10.1` in `pyproject.toml` out of an abundance of caution re: recent issues with `2.10.2` (which has since been yanked from PyPI) * small adjustment to `pypocketfft.cxx` to defened against the segfault that occurs with pybind11 `2.10.2` (arguably not a bug, but safer way to initialize here)
[skip azp] [skip actions] [skip cirrus]
4783c5e
to
205b624
Compare
I rewrote the history of this branch as requested, including a clearer commit message for the 3 newly-squashed commits. If the CI passes again, I'll merge and start the release process. |
1.10.0
not being released yet--let me know if you'd prefer that I do an RC3 instead of the final release at this stagepybind11
to version2.10.1
inpyproject.toml
out of an abundance of caution--we really should be safe to unpin because:pybind11
2.10.2
has been yanked from PyPI1.10.0
, and then relax this later in the1.10.x
series if things are looking solid with newerpybind11
patch releases? (they almost certainly should be just fine)