New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: interpolate: Extrapolation tips and tricks #17299
Conversation
63377e6
to
c991283
Compare
CI failures are unrelated, as it is a pure DOC change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is all new and the information is correct/useful, I think we can merge this pretty quickly.
I agree that this closes the issues if you think it would make the API too messy to include options for these things.
I've only made it halfway through. Next pass I'll start from "Manually implement the asymptotic".
… extrapolation The example is contributed by Shamus Husheer in scipygh-14472. Co-authored-by: Shamus Husheer <s.husheer@gmail.com>
The example is contributed by Ajay Shanker Tripathi in scipygh-14386
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
[skip azp] [skip actions]
8c0f9b7
to
c18c3b5
Compare
[skip cirrus] [skip azp] [skip actions]
I think the last commit addresses all review suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments
[skip azp] [skip cirrus] [skip actions]
Thanks Jake for the review, I tried to address your comments in the last commit in this branch. |
I wanted to finish my review, but the rendered artifacts are not available right now for some reason (looks like a CircleCI issue). Since I'm not very familiar with these functions, the rendered documentation is important, so I'll have to come back. I'll try to look at the rest (starting at "Manually Implement the Asymptotics") on Thursday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ev-br that is my comments addressed
Oh, the only question is what we should do about co-authorship of @chausies. I see you asked whether they'd like to be credited, but there is no response. What would you like to do? Besides #14472 (comment), you can usually find real email addresses by adding |
Thanks Matt, Jake for the reviews! |
Reference issue
closes gh-16338, closes gh-14386, closes gh-14472
What does this implement/fix?
Add a tutorial page with several worked examples of extrapolation--- handling out-of-bounds data --- in several interpolators. In general, extrapolation is not entirely consistent in scpy.interpolate, default modes are not always useful, and in some cases manual work on the user side is needed. There are four examples, of both using the existing keyword switches etc, and DIY implementations.
Additional information
Two out of four examples are provided by users, in gh-14386 and gh-14472. Am crediting the users in the commit messages, will comment on the issues to see if they want to be listed as commit co-authors.