Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove certifi py3.11 warning filter #17149

Merged
merged 2 commits into from Oct 5, 2022

Conversation

AnirudhDagar
Copy link
Member

Reference issue

#16983

What does this implement/fix?

certifi made a release recently, which includes a fix for the py3.11 deprecation warning that popped up before (certifi/python-certifi@47fb7ab). requests (pooch dependency) should now pick up the latest version of certifi. Thus we should be able to remove these warning filters on the pooch import.

@AnirudhDagar AnirudhDagar added scipy.datasets maintenance Items related to regular maintenance tasks labels Oct 4, 2022
@AnirudhDagar AnirudhDagar mentioned this pull request Oct 4, 2022
10 tasks
@AnirudhDagar
Copy link
Member Author

Ahh, forgot to remove import warnings.

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnirudhDagar. CI is green and another approval, merging :)

@tupui tupui merged commit bf2934b into scipy:main Oct 5, 2022
@tupui tupui added this to the 1.10.0 milestone Oct 5, 2022
@AnirudhDagar AnirudhDagar deleted the remove_pooch_warnings branch October 5, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants