-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: move test_numpy_main to linux_meson #16742
Conversation
[skip azp] [skip circle]
@rgommers CI is green. LMK if there is anything to adapt here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- do we want the maintenance skip (
if: "github.repository == 'scipy/scipy' && !contains(github.ref, 'maintenance/') && !contains(github.base_ref, 'maintenance/')"
). I think this is a leftover as we have theon: push: branches
specification.
We do need this. The first part is: "don't run on forks" (not a leftover, wanted in all jobs). The second part is "don't run the testing against main branches of dependencies in maintenance branches". That tends to fail and we disabled it on purpose.
There's one issue here now though: since you mixed this job with the 3.9
job, we cannot easily disable just one of these.
2. do we really need
setuptools==59.8.0 wheel
in the 3.9 job??
It looks like that is a leftover indeed, can you remove it?
Yes I was referring to the second part only. I can just make a second conditional clause to skip if 3.11 & maintenance. |
[skip azp] [skip circle]
Looks like the added job is not running. You probably should iterate on this in a PR to your own fork. The way I do that is add a single WIP commit, changing |
After some googling, this happens because the matrix part cannot be used at that point. Apparently I could use exclude to do this. I will try on my fork if you prefer then. |
[skip azp] [skip circle]
The Mypy step isn't erroring out when it should:
That is already happening in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @tupui!
Follow up of #16739
I am not sure about 2 things:
if: "github.repository == 'scipy/scipy' && !contains(github.ref, 'maintenance/') && !contains(github.base_ref, 'maintenance/')"
). I think this is a leftover as we have theon: push: branches
specification.setuptools==59.8.0 wheel
in the 3.9 job??