Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: move test_numpy_main to linux_meson #16742

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Conversation

tupui
Copy link
Member

@tupui tupui commented Jul 29, 2022

Follow up of #16739

I am not sure about 2 things:

  1. do we want the maintenance skip (if: "github.repository == 'scipy/scipy' && !contains(github.ref, 'maintenance/') && !contains(github.base_ref, 'maintenance/')"). I think this is a leftover as we have the on: push: branches specification.
  2. do we really need setuptools==59.8.0 wheel in the 3.9 job??

@tupui tupui added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Jul 29, 2022
@tupui tupui added this to the 1.10.0 milestone Jul 29, 2022
@tupui tupui requested a review from rgommers July 29, 2022 21:51
@tupui
Copy link
Member Author

tupui commented Jul 30, 2022

@rgommers CI is green. LMK if there is anything to adapt here.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. do we want the maintenance skip (if: "github.repository == 'scipy/scipy' && !contains(github.ref, 'maintenance/') && !contains(github.base_ref, 'maintenance/')"). I think this is a leftover as we have the on: push: branches specification.

We do need this. The first part is: "don't run on forks" (not a leftover, wanted in all jobs). The second part is "don't run the testing against main branches of dependencies in maintenance branches". That tends to fail and we disabled it on purpose.

There's one issue here now though: since you mixed this job with the 3.9 job, we cannot easily disable just one of these.

2. do we really need setuptools==59.8.0 wheel in the 3.9 job??

It looks like that is a leftover indeed, can you remove it?

.github/workflows/linux_meson.yml Outdated Show resolved Hide resolved
@tupui
Copy link
Member Author

tupui commented Jul 31, 2022

We do need this. The first part is: "don't run on forks" (not a leftover, wanted in all jobs). The second part is "don't run the testing against main branches of dependencies in maintenance branches". That tends to fail and we disabled it on purpose.
There's one issue here now though: since you mixed this job with the 3.9 job, we cannot easily disable just one of these.

Yes I was referring to the second part only. I can just make a second conditional clause to skip if 3.11 & maintenance.

[skip azp] [skip circle]
@rgommers
Copy link
Member

rgommers commented Aug 1, 2022

Looks like the added job is not running. You probably should iterate on this in a PR to your own fork. The way I do that is add a single WIP commit, changing main to the name of the branch I'm working in and scipy/scipy in the skip condition to rgommers/scipy; that way only the job you are working on will run.

@tupui
Copy link
Member Author

tupui commented Aug 4, 2022

After some googling, this happens because the matrix part cannot be used at that point. Apparently I could use exclude to do this. I will try on my fork if you prefer then.

[skip azp] [skip circle]
@tupui
Copy link
Member Author

tupui commented Aug 4, 2022

Ok I think I got it with exclusion pattern and it's easier to read IMO. See tupui#8 and tupui#9 to see it in action.

@rgommers
Copy link
Member

rgommers commented Aug 4, 2022

The Mypy step isn't erroring out when it should:

Installation OK
scipy/integrate/setup.py:4: error: Cannot find implementation or library stub for module named "scipy._build_utils"  [import]
scipy/integrate/setup.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
scipy/integrate/setup.py:9: error: Cannot find implementation or library stub for module named "scipy._build_utils.system_info"  [import]
scipy/stats/_hypotests.py:14: error: Cannot find implementation or library stub for module named "scipy.stats._hypotests_pythran"  [import]
Found 3 errors in 2 files (checked 783 source files)

That is already happening in main though, so let's ignore it here. I can reproduce it locally as well. I'll send a separate fix for that.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tupui!

@rgommers rgommers merged commit eaa7421 into scipy:main Aug 4, 2022
@tupui tupui deleted the ci_meson_linux branch August 4, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants