New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: stats: resampling and Monte Carlo methods tutorial #16699
Conversation
[skip actions] [skip azp]
[skip actions] [skip azp]
@tirthasheshpatel how did you write the |
Nice 👍 just a fly by comment for now (as you said you wanted Nicholas to review first). Don't forget to remove the global seeding and use a generator. Also I am thinking that we could reorganise the existing unuran, QMC and this. There are common things at least in the introduction (e.g. in QMC there is a description of MC vs QMC) and we should probably have QMC as a standalone page as you are doing here. |
I wrote them directly in ReST. You can also try using pandoc to convert Jupyter Notebooks to (github-flavored) markdown (or HTML) first and In case of Jupytest Notebooks though, I think it would be better to add all the notebooks in a new directory called |
simple Monte Carlo approach was more accurate than the normal | ||
approximation. This is not uncommon: when an exact answer is unknown, | ||
often a computational approximation is more accurate than an analytical | ||
approximation. Also, it’s easy for demons to invent questions for which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nitpick: I've had trouble with these special characters when using simple text editors on Linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must have happened during automatic conversion from the notebook.
@mdhaber This is looking really good to me, I just added some nitpicks and pointed out another usage |
Thanks @mckib2. All of your comments are good. Any opinions on what format these should be in? Converting these to restructured text has been a bit of a pain, and I don't think they're as useful as if they were notebooks. On the other hand, it's much nicer to work with human-readable text with git. The way matplotlib and scikit-learn do their examples might be a good compromise? Anyway, do you have ideas? |
That might be a great compromise. I was thinking that maybe the As for whether they are part of SciPy or are in a separate repo, I don't really have an opinion. |
[skip azp] [skip actions]
[skip actions] [skip azp]
[skip actions] [skip azp]
OK, I think I implemented @tirthasheshpatel's suggestion to add the notbooks to a new folder and link to them from the original starting point
This might be better because currently when you try to execute the notebooks in Binder (from nbviewer), the build succeeds but BTW I know I need to check that citations are numbered sequentially throughout and add references at the bottom of each page. There were also some comments I tried to add as footnotes that look wonky right now. I'm waiting until we figure out exactly how these are being published before I spend time on this. |
Yes, a separate repo sounds better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[skip azp] [skip actions]
@tirthasheshpatel et al. here's the plan:
@melissawm @rossbar Can you help us set up those sort of tutorials for SciPy? This is exactly what we were looking for, I think. |
+1 on doing the same as NumPy. This looks very nice and with all the features we want I think.
Fine for now until we have the new repo/setup. After which we should think about moving over what we want from the cookbook and archiving the repo. |
[skip azp] [skip actions]
As notebooks are discussed, linking a stale issue #5233 |
|
[skip actions] [skip azp]
Looks like a comments are resolved and the plan to link to cookbooks is generally accepted. In it goes -- thanks @mdhaber, apologies for the delay in review |
Reference issue
What does this implement/fix?
This is a draft of the first part a
scipy.stats
resampling and Monte Carlo methods tutorial. I had a little fun with the introduction; the rest is pretty formal. @mckib2 is slated to review.Additional information
Can't build docs locally. Fingers crossed.