Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pin Pip to 22.0.4 to avoid issues with --no-build-isolation #16172

Merged
merged 1 commit into from May 13, 2022

Conversation

rgommers
Copy link
Member

This change can be reverted once Pip releases its next version with a fix for pypa/pip#11116.

At the moment all our Azure builds are failing with errors like:

ERROR: Some build dependencies for file:///D:/a/1/s conflict with the backend dependencies:
numpy==1.21.4 is incompatible with numpy==1.18.5; python_version=='3.8' and (platform_machine!='arm64' or platform_system!='Darwin') and platform_machine!='aarch64' and platform_python_implementation != 'PyPy'.

The short summary of the issue is: pip 22.1 is unusable for us with --no-build-isolation, since it trips up over the pins in our pyproject.toml file.

[skip github]

This change can be reverted once Pip releases its next version with
a fix for pypa/pip#11116.

At the moment all our Azure builds are failing with errors like:
```
ERROR: Some build dependencies for file:///D:/a/1/s conflict with the backend dependencies:
numpy==1.21.4 is incompatible with numpy==1.18.5; python_version=='3.8' and (platform_machine!='arm64' or platform_system!='Darwin') and platform_machine!='aarch64' and platform_python_implementation != 'PyPy'.
```

[skip github]
@rgommers rgommers added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label May 13, 2022
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 13, 2022
@tylerjereddy tylerjereddy added this to the 1.9.0 milestone May 13, 2022
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is affecting other projects I help with too. Since there is already a passing Azure job using the pinned pip let's put it straight in, clearly correct for now.

@tylerjereddy tylerjereddy merged commit 0ded4f6 into scipy:main May 13, 2022
@rgommers rgommers deleted the ci-pin-pip branch May 13, 2022 18:50
@tylerjereddy tylerjereddy modified the milestones: 1.9.0, 1.8.1 May 15, 2022
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 19, 2022
@EwoutH
Copy link
Contributor

EwoutH commented May 23, 2022

With pypa/pip#11117 a fix was implemented for this issue, which was included in the 22.1.1 release. So I think this PR can be reverted.

@rgommers
Copy link
Member Author

Thanks @EwoutH! Opened gh-16259 to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants