Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, MAINT: pin Cython for azure pre-rel #14801

Merged
merged 1 commit into from Oct 4, 2021

Conversation

tylerjereddy
Copy link
Contributor

python runtests.py -t "scipy/interpolate/tests/test_rbfinterp.py" -- -n 2

  • so, pin the max Cython version to <3.0a5 for now (pip should still
    install stable release when --pre is not used in other Azure CI
    entries)

  • obviously this is just a workaround--I'll open an upstream issue
    to see if there are any suspicions about a possible bug or something
    else we might do differently to avoid the segfault

* for about 3 weeks pre-release CI has been failing as described
in scipygh-14732

* I bisected the pre-release versions of Cython `3.x` that are
available on PyPI locally and found that the first version to
reproduced a sefault for the command below is `3.0a5`

`python runtests.py -t "scipy/interpolate/tests/test_rbfinterp.py" -- -n 2`

* so, pin the max Cython version to `<3.0a5` for now (pip should still
install stable release when `--pre` is not used in other Azure CI
entries

* obviously this is just a workaround--I'll open an upstream issue
to see if there are any suspicions about a possible bug or something
else we might do differently to avoid the segfault
@tylerjereddy tylerjereddy added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Oct 4, 2021
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 4, 2021
@tylerjereddy
Copy link
Contributor Author

The "Main coverage.." Azure failure looks unrelated--already happening in: gh-14798

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for tracking that down Tyler!

This fixes the problem; the two CI failures are unrelated. So in it goes.

@rgommers rgommers merged commit b47ecb4 into scipy:master Oct 4, 2021
@rgommers rgommers added this to the 1.8.0 milestone Oct 4, 2021
@tupui
Copy link
Member

tupui commented Oct 4, 2021

For the coverage, I am debugging. It's from the update of coverage from 5.5 to 6. pytest-cov got updated as well but the changes do not indicate that it's from there.

@tupui
Copy link
Member

tupui commented Oct 4, 2021

#14653 could be a good place to fix the coverage.

@tupui
Copy link
Member

tupui commented Oct 4, 2021

Ok confirming this, in a passing job we do have Coverage.py warning: --include is ignored because --source is set (include-ignored). I will do a PR for a quick fix.

@tylerjereddy tylerjereddy deleted the treddy_issue_14732_workaround branch October 4, 2021 15:06
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 6, 2021
@tylerjereddy
Copy link
Contributor Author

I've stripped the backport label here now that we have a proper fix in gh-14813 and a reversion of the version pin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants