MAINT: prepare for SciPy 1.10.0 "final" #17696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is all green with no skip directive active. There was a request to add a missing contributor (#14386 (comment)), so I'm now going to push in a commit that does that, but skips most of the CI outside of docs stuff. |
|
@rgommers I think this is probably ready to go--if you want me to proceed differently with the |
rgommers
approved these changes
Jan 3, 2023
* remove the pybind11 version exclusion from Windows Meson job in GitHub actions * pin pybind11 to version `2.10.1` in `pyproject.toml` out of an abundance of caution re: recent issues with `2.10.2` (which has since been yanked from PyPI) * small adjustment to `pypocketfft.cxx` to defened against the segfault that occurs with pybind11 `2.10.2` (arguably not a bug, but safer way to initialize here)
[skip azp] [skip actions] [skip cirrus]
tylerjereddy
force-pushed
the
treddy_110_final_prep
branch
from
4783c5e
to
205b624
Compare
|
I rewrote the history of this branch as requested, including a clearer commit message for the 3 newly-squashed commits. If the CI passes again, I'll merge and start the release process. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.10.0not being released yet--let me know if you'd prefer that I do an RC3 instead of the final release at this stagepybind11to version2.10.1inpyproject.tomlout of an abundance of caution--we really should be safe to unpin because:pybind112.10.2has been yanked from PyPI1.10.0, and then relax this later in the1.10.xseries if things are looking solid with newerpybind11patch releases? (they almost certainly should be just fine)