Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use hatch envs instead of nox #40

Merged
merged 13 commits into from Nov 30, 2022
Merged

feat: Use hatch envs instead of nox #40

merged 13 commits into from Nov 30, 2022

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Nov 29, 2022

This PR migrates from nox to hatch env updating the following files initially created by scikit-hep/cookie:

  • .github/CONTRIBUTING.md
  • .github/workflows/ci.yml
  • pyproject.toml

Two particular notes:

  • chose not to put pre-commit in the hatch env, although I certainly could have done so, it feels like pre-commit belongs outside of the package fundamentally
  • chose to define matrix of python versions in hatch env for the pytest to keep the equivalent functionality that nox had (as best as I could) -- but this does come with the minor caveat that one needs to keep the version consistent between the matrices in .github/workflows/ci.yml and pyproject.toml as I use hatch run +py=${{ matrix.python-version}} dev:test to pick out the version to run.

@kratsg
Copy link
Contributor Author

kratsg commented Nov 29, 2022

We can't use --strict just yet as we're blocked by incompatibility between two projects, see timvink/mkdocs-git-revision-date-localized-plugin#101 for details.

@kratsg
Copy link
Contributor Author

kratsg commented Nov 30, 2022

@henryiii - this PR represents transitioning from noxfile.py to hatch env fully.

@kratsg kratsg merged commit 1359037 into main Nov 30, 2022
@kratsg kratsg deleted the feat/hatchEnvs branch November 30, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant