Correct the reference link for additive chi squared sampler. #4860
Conversation
| @@ -245,9 +245,8 @@ class AdditiveChi2Sampler(BaseEstimator, TransformerMixin): | |||
| References | |||
| ---------- | |||
| See `"Efficient additive kernels via explicit feature maps" | |||
| <http://eprints.pascal-network.org/archive/00006964/01/vedaldi10.pdf>`_ | |||
| <http://citeseer.ist.psu.edu/viewdoc/summary?doi=10.1.1.167.7024>`_ | |||
There was a problem hiding this comment.
We could link straight to the PDF on the lead author's website.
It seems there is also an extended journal version that we might want to refer to instead. (The citation for this one would be A. Vedaldi and A. Zisserman, Pattern Analysis and Machine Intelligence, 2011.)
Thoughts?
There was a problem hiding this comment.
I thought citeceerx would be more stable and the link would still be alive even if anything happens to the external PDF link like what happened now...
But yes the extended journal link would be better to have though! I think we could link the journal version and have #4344 (comment) for checking all our links!!
There was a problem hiding this comment.
If you're going to change to the journal, please do so this PR can be disappeared!
raghavrv
force-pushed
the
additive_chi2_sampler_reflink
branch
from
32f902c
to
b40c76a
Compare
| <http://eprints.pascal-network.org/archive/00006964/01/vedaldi10.pdf>`_ | ||
| Vedaldi, A. and Zisserman, A., Computer Vision and Pattern Recognition 2010 | ||
|
|
||
| <http://www.robots.ox.ac.uk/%7Evedaldi/assets/pubs/vedaldi11efficient.pdf>`_ |
There was a problem hiding this comment.
That was close... it was exactly 80 chars!
There was a problem hiding this comment.
Could you replace the %7E with a ~ please, and check that the link works in the HTML reference after rendering the docs? If this works, this is done. Thanks!
raghavrv
force-pushed
the
additive_chi2_sampler_reflink
branch
from
b40c76a
to
71c004b
Compare
Correct the reference link for additive chi squared sampler.
|
Thanks!! |
|
Thanks @rvraghav93! |
A minor PR.
Please take a look @GaelVaroquaux @agramfort :)