Add conventions section to userguide. #4508 (rebase) #4594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You still have the "Merge ..." commits that are best removed to keep a simple history. I suggested how to do that in the original PR. I reckon the best is to keep working on this in the original PR and close this one. |
|
I'll do the squashing for now, for the future see @lesteve's comment in the other pr. |
|
pushed to master as 0fe613e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds conventions section with two subsections about a) type casting and b) updating model parameters to quick-start userguide (#4508). Similar to #4566, but branch was first rebased to master.