Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 🤖 CI Update lock files for pypy CI build(s) 🔒 🤖 #28869

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 11e5ae9. Link to the linter CI: here

@ogrisel
Copy link
Member

ogrisel commented Apr 22, 2024

This fails when running test_import_all_consistency (sklearn/tests/test_common.py:230) when importing the Cython module sklearn.datasets._svmlight_format_fast:

ValueError: array.array size changed, may indicate binary incompatibility. Expected 72 from C header, got 24 from PyObject

This seems to be a real regression because the scheduled PyPy tests ran successfully last night on main:

https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=65968&view=logs&j=0b16f832-29d6-5b92-1c23-eb006f606a66&t=0cdfadab-878f-502c-9df1-54a896e98c4f

@ogrisel
Copy link
Member

ogrisel commented Apr 22, 2024

According to this message pyproj4/pyproj#854 (comment) it seems that using array.array in Cython (with PyPy in particular) is inherently problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants