MAINT Clean-up utils.__init__: move tests into corresponding test files #28842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
added
No Changelog Needed
Quick Review
jeremiedbb
commented
Apr 15, 2024
Comment on lines
-37
to
-74
| def test_deprecated(): | ||
| # Test whether the deprecated decorator issues appropriate warnings | ||
| # Copied almost verbatim from https://docs.python.org/library/warnings.html | ||
|
|
||
| # First a function... | ||
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter("always") | ||
|
|
||
| @deprecated() | ||
| def ham(): | ||
| return "spam" | ||
|
|
||
| spam = ham() | ||
|
|
||
| assert spam == "spam" # function must remain usable | ||
|
|
||
| assert len(w) == 1 | ||
| assert issubclass(w[0].category, FutureWarning) | ||
| assert "deprecated" in str(w[0].message).lower() | ||
|
|
||
| # ... then a class. | ||
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter("always") | ||
|
|
||
| @deprecated("don't use this") | ||
| class Ham: | ||
| SPAM = 1 | ||
|
|
||
| ham = Ham() | ||
|
|
||
| assert hasattr(ham, "SPAM") | ||
|
|
||
| assert len(w) == 1 | ||
| assert issubclass(w[0].category, FutureWarning) | ||
| assert "deprecated" in str(w[0].message).lower() |
There was a problem hiding this comment.
This one I just removed it because it's redundant and strickly less exhaustive than the test_deprecated function already in test_deprecation.py.
adrinjalali
approved these changes
Apr 16, 2024
glemaitre
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on the PRs cleaning-up
utils.__init__. In the first PRs I made, I just moved the functions outside of init, leaving the tests of these functions intotest_utils.