MAINT Clean up deprecations for 1.5: in NearestCentroid #28813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
added
No Changelog Needed
Quick Review
ogrisel
reviewed
Apr 22, 2024
| If `metric="euclidean"`, the centroid for the samples corresponding to each | ||
| class is the arithmetic mean, which minimizes the sum of squared L1 distances. | ||
| If `metric="manhattan"`, the centroid is the feature-wise median, which | ||
| minimizes the sum of L1 distances. | ||
|
|
||
| .. deprecated:: 1.3 | ||
| Support for metrics other than `euclidean` and `manhattan` and for |
There was a problem hiding this comment.
This section should be updated as a versionchanged (as done for the metric='precomputed' case in 0.19) or just removed (but then the previous versionchanged should also be removed for consistency).
| @@ -111,12 +103,7 @@ class NearestCentroid(ClassifierMixin, BaseEstimator): | |||
| _valid_metrics = set(_VALID_METRICS) - {"mahalanobis", "seuclidean", "wminkowski"} | |||
There was a problem hiding this comment.
This attribute can probably also be deleted, no?
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
jeremiedbb
commented
Apr 26, 2024
adrinjalali
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the deprecated metrics from
NearestCentroid(everything but euclidean and manhattan).I also reworked the docstring a bit because it was wrong: