[MRG] Add a note to inspection.partial_dependence() about different results when using brute and recursion method #28771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glemaitre all tests pass (except the changelog entry, not sure if it is required), and the PR is ready for review. Hence adding [MRG] to the title. Kindly let me know if I missed something! |
nihal-rao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28595 . By extension, also fixes #27441 .
What does this implement/fix? Explain your changes.
PR #28595 had a failing test due to incorrect ordering of sections in the dosctring of
partial_dependencefunction.Fixed this by correcting the order of the 'Notes' and 'See Also' sections in the docstring .
Any other comments?