Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add Friedman's H-squared #28375

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

ENH Add Friedman's H-squared #28375

wants to merge 59 commits into from
+726 −3

Commits on Feb 6, 2024

  1. Add Friedman's H-squared of pairwise interaction statistics

    @mayer79
    mayer79 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2f06cbc View commit details
    Browse the repository at this point in the history

  2. run black

    @mayer79
    mayer79 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    38f3d6c View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. np.unique() does not work well for non-standard values

    @mayer79
    mayer79 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f173c51 View commit details
    Browse the repository at this point in the history

  2. Reorganize imports

    @mayer79
    mayer79 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2e7b731 View commit details
    Browse the repository at this point in the history

  3. run ruff

    @mayer79
    mayer79 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    64581e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. check weights and is fitted

    mayer79 authored and mayer79 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8e50637 View commit details
    Browse the repository at this point in the history

  2. Replace compression logic by try except

    mayer79 authored and mayer79 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    efa4071 View commit details
    Browse the repository at this point in the history

  3. Switch to Bunch output

    mayer79 authored and mayer79 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f53b838 View commit details
    Browse the repository at this point in the history

  4. Clip small numerators

    mayer79 authored and mayer79 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    032e661 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
    @mayer79 @lorentzenchr
    mayer79 and lorentzenchr committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1335f05 View commit details
    Browse the repository at this point in the history

  2. use sample_without_replacement, plus some docstring improvements

    @mayer79
    mayer79 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    a28e8e0 View commit details
    Browse the repository at this point in the history

  3. fix existing problems

    @mayer79
    mayer79 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    66f7bdd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into friedmans-h

    @mayer79
    mayer79 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6db5ac7 View commit details
    Browse the repository at this point in the history

  5. Rename things and fix imports

    @mayer79
    mayer79 committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5beb941 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. More compact output organization, faster example

    @mayer79
    mayer79 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    9823fe5 View commit details
    Browse the repository at this point in the history

  2. Add formula to docstring

    @mayer79
    mayer79 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    5aebb4c View commit details
    Browse the repository at this point in the history

  3. Add preliminary unit tests

    @mayer79
    mayer79 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    36ed7a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Compare against two R packages

    @mayer79
    mayer79 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    27e3540 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Split calculate_pd_over_data into two plus some optimizations

    @mayer79
    mayer79 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e5f6e53 View commit details
    Browse the repository at this point in the history

  2. Fix typos in docstring

    @mayer79
    mayer79 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a2b659d View commit details
    Browse the repository at this point in the history

  3. Fix example output in docstring

    @mayer79
    mayer79 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    69111e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
    @mayer79 @lorentzenchr
    mayer79 and lorentzenchr committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    0416de3 View commit details
    Browse the repository at this point in the history

  2. More changed from review

    @mayer79
    mayer79 committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    3fe5d64 View commit details
    Browse the repository at this point in the history

  3. add validate_params()

    @mayer79
    mayer79 committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    c583aeb View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Add h_statistic to test_public_functions.py

    @mayer79
    mayer79 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a443f02 View commit details
    Browse the repository at this point in the history

  2. Possession apostrophs

    @mayer79
    mayer79 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a3aaed4 View commit details
    Browse the repository at this point in the history

  3. Add docu

    @mayer79
    mayer79 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    95ed5de View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Add entry to classes.rst

    @mayer79
    mayer79 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7f4527f View commit details
    Browse the repository at this point in the history

  2. reorder position in classes.rst

    @mayer79
    mayer79 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0ee0f7a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into friedmans-h

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    309edef View commit details
    Browse the repository at this point in the history

  2. safe assign and indexing have moved

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    a93a4c9 View commit details
    Browse the repository at this point in the history

  3. Fix doctest failure

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6b63a55 View commit details
    Browse the repository at this point in the history

  4. fix docstring failure attempt 2

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3923d73 View commit details
    Browse the repository at this point in the history

  5. doc tests do not seem to allow multiline command in parantheses

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d406dc6 View commit details
    Browse the repository at this point in the history

  6. docstring checks do not like black

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    70b9f68 View commit details
    Browse the repository at this point in the history

  7. assign result of plot in docu

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3ed07af View commit details
    Browse the repository at this point in the history

  8. superfluous newline in docstring of function

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c7b798e View commit details
    Browse the repository at this point in the history

  9. Replace plot by print()

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7e4ff8b View commit details
    Browse the repository at this point in the history

  10. rst docu: reformat code

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c5e56ab View commit details
    Browse the repository at this point in the history

  11. Change intendation in example output of rst docu

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9ed9b2b View commit details
    Browse the repository at this point in the history

  12. doctest failure

    @mayer79
    mayer79 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0b29fc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. documentation: image is better than print

    @mayer79
    mayer79 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    5845331 View commit details
    Browse the repository at this point in the history

  2. Intendation fix

    @mayer79
    mayer79 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    91c2d65 View commit details
    Browse the repository at this point in the history

  3. fix doctest issues

    @mayer79
    mayer79 committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    25a3f6d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Review Lorentzen

    @mayer79
    mayer79 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    72ce9c7 View commit details
    Browse the repository at this point in the history

  2. switch to pred_fun argument in helper

    @mayer79
    mayer79 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    cde7dae View commit details
    Browse the repository at this point in the history

  3. Initialize all resulting numpy arrays

    @mayer79
    mayer79 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a3f1beb View commit details
    Browse the repository at this point in the history

  4. Too long line in docstring

    @mayer79
    mayer79 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ffc6b77 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Doctest failure

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ef20380 View commit details
    Browse the repository at this point in the history

  2. move example from rst file to plot_partial_dependence.py

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    3a34272 View commit details
    Browse the repository at this point in the history

  3. Reformat example output

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    4658ee6 View commit details
    Browse the repository at this point in the history

  4. Fixing plot

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    9bc1ff8 View commit details
    Browse the repository at this point in the history

  5. Fix reference

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    9b8a1d6 View commit details
    Browse the repository at this point in the history

  6. maybe we need copy()

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a5cfa08 View commit details
    Browse the repository at this point in the history

  7. Try second copy()

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f36a913 View commit details
    Browse the repository at this point in the history

  8. Remove copy again

    @mayer79
    mayer79 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    54e98c8 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. fix dupe index issue with old pandas

    @mayer79
    mayer79 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    131910b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Fix typo

    @mayer79
    mayer79 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    00f0eed View commit details
    Browse the repository at this point in the history

  2. add column names to pandas unit test

    @mayer79
    mayer79 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    90ffd7b View commit details
    Browse the repository at this point in the history