MAINT Make ArgKminClassMode accept sparse datasets
#27018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
thomasjpfan
reviewed
Aug 7, 2023
Micky774
approved these changes
Aug 8, 2023
Actually we can avoid that by specifying |
Micky774
requested changes
Aug 8, 2023
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Meekail Zain <Micky774@users.noreply.github.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
maint/make-ArgKminClassMode-accept-sparse-datasets
branch
from
8eb58b0
to
72d1945
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
thomasjpfan
approved these changes
Aug 15, 2023
jjerphan
deleted the
maint/make-ArgKminClassMode-accept-sparse-datasets
branch
TamaraAtanasoska
pushed a commit
to TamaraAtanasoska/scikit-learn
that referenced
this pull request
Aug 21, 2023
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow-up of #24076.
What does this implement/fix? Explain your changes.
#24076 had a guard for the limitation on sparse datasets #23585 resolved, but #23585 was merged without #24076 being updated accordingly.
This PR removes this limiting guard.
Any other comments?
Even if
ArgKminClassModeis the only class which overloadsis_usable_for, I have not added tests to check this behavior not to complexify the test suite too much. Should I?Also, do we need a changelog entry?