Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2.0 #25121

Merged
merged 17 commits into from Dec 8, 2022
Merged

Release 1.2.0 #25121

merged 17 commits into from Dec 8, 2022

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Dec 6, 2022 •
edited

  • update news and what's new date in release branch
  • update news and what's new date and sklearn dev0 version in main branch
  • check that the wheels for the release can be built successfully
  • merge the PR with [cd build] commit message to upload wheels to the staging repo
  • upload the wheels and source tarball to https://test.pypi.org
  • create tag on the main github repo
  • confirm bot detected at
    https://github.com/conda-forge/scikit-learn-feedstock and wait for merge
  • upload the wheels and source tarball to PyPI
  • https://github.com/scikit-learn/scikit-learn/releases publish (except for RC)
  • announce on mailing list and on Twitter, and LinkedIn
  • update SECURITY.md in main branch (except for RC)

glemaitre and others added 14 commits December 6, 2022 17:11
@glemaitre @lorentzenchr @jeremiedbb
ENH cartesian accepts mixed dtypes arrays (scikit-learn#25067)
d956100 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@thomasjpfan @jeremiedbb
BLD Reduce binary size of wheels (scikit-learn#25063)
bc51791
@glemaitre @jeremiedbb
DOC adding PDP for categorical features in highlights (scikit-learn#2…
52b0dd5 
…5065)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@thomasjpfan @jeremiedbb
FIX Fixes check_array for pd.NA in a series (scikit-learn#25080)
53cb1fc
@jeremiedbb
MAINT Make param validation more lenient towards downstream dependenc…
5d594f3 
…ies (scikit-learn#25088)
@thomasjpfan @jeremiedbb
CI Fixes CI for windows (scikit-learn#25091)
2604cb9
@ArturoAmorQ @glemaitre @jeremiedbb
FIX Array validation for DecisionBoundaryDisplay (scikit-learn#25077)
05810b2 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@ogrisel @jeremiedbb
ENH better error message in HGBRT with feature names (scikit-learn#25092
b6d3f2a 
)

Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
@thomasjpfan @jeremiedbb
MNT Require matplotlib in test_input_data_dimension test (scikit-lear…
87b8c1f 
…n#25104)
@glemaitre @betatim
@jjerphan @jeremiedbb
FIX always expose best_loss_, validation_scores_, and best_validation…
42ba710 
…_score (scikit-learn#24683)

Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@jeremiedbb
MAINT Allow partial param validation for functions (scikit-learn#25087)
6fbe0db
@jeremiedbb
update version number
092d981
@jeremiedbb
update checklist to mention SECURITY.md
6fb6b6a
@jeremiedbb
[cd build]
bbac0aa
@thomasjpfan
Copy link
Member

I think #25123 would be nice to include in the release since it reduces the Linux wheel size from 36.6 MB to 9.8 MB.

@glemaitre
Copy link
Member

Also #25129: we raise spurious warnings that will be annoying. It will be a quick fix.

thomasjpfan
thomasjpfan approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jjerphan
jjerphan approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jeremiedbb!

@jeremiedbb jeremiedbb merged commit dc580a8 into scikit-learn:1.2.X Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeremiedbb @thomasjpfan @glemaitre @jjerphan @ArturoAmorQ @ogrisel