DOC correct link for image in the PDP documentation #25054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmarmo
added
the
To backport
glemaitre
changed the title
|
Thanks @madhuracj for picking this one up. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Nov 28, 2022
Thanks, but credit to you, you did most of the heavy lifting. I was a bit busy lately and couldn't find time to address review comments. Thanks for pushing the PR forward. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Bug introduced in commit c1cfc4d (PR: #18298, issue: #14969)
What does this implement/fix? Explain your changes.
The text in the example https://scikit-learn.org/dev/modules/partial_dependence.html says
However, a figure with just two one-way PDPs is shown. This PR links the correct figure containing two one-way and one two-way PDPs.
Any other comments?