Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Pin numpy for conda defaults channel #24373

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Sep 6, 2022

Reference Issues/PRs

Seen in #24363 (comment)

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@@ -108,6 +108,13 @@ def remove_from(alist, to_remove):
"conda_dependencies": common_dependencies + ["ccache"],
"package_constraints": {
"blas": "[build=mkl]",
# 2022-06-09 currently mamba install 1.23 and scipy 1.7 which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue related to mamba? If not, could we use "conda" here instead?

Suggested change
# 2022-06-09 currently mamba install 1.23 and scipy 1.7 which
# 2022-06-09 currently conda install 1.23 and scipy 1.7 which

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the comment to talk about available version in conda defaults channel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I am also confused. Our CI relies on conda-lock to resolve the dependencies which probably uses conda under the hood. Why mention mamba in the comment if this is the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters too much here, but off the top of my head conda-lock uses mamba if available so I am guessing that we actually use mamba to generate the lock files ...

@lesteve
Copy link
Member Author

lesteve commented Sep 6, 2022

@lesteve
Copy link
Member Author

lesteve commented Sep 6, 2022

The macOS pylatest_conda_mkl_no_openmp is green https://github.com/scikit-learn/scikit-learn/pull/24373/checks?check_run_id=8208937669 (kind of expected since I only change the comment)

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then, let's merge!

@ogrisel ogrisel merged commit 7f87362 into scikit-learn:main Sep 6, 2022
@lesteve lesteve deleted the update-conda-defaults-noopenmp branch September 6, 2022 17:46
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants