-
-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pin numpy for conda defaults channel #24373
CI Pin numpy for conda defaults channel #24373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
@@ -108,6 +108,13 @@ def remove_from(alist, to_remove): | |||
"conda_dependencies": common_dependencies + ["ccache"], | |||
"package_constraints": { | |||
"blas": "[build=mkl]", | |||
# 2022-06-09 currently mamba install 1.23 and scipy 1.7 which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this issue related to mamba? If not, could we use "conda" here instead?
# 2022-06-09 currently mamba install 1.23 and scipy 1.7 which | |
# 2022-06-09 currently conda install 1.23 and scipy 1.7 which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the comment to talk about available version in conda defaults channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I am also confused. Our CI relies on conda-lock to resolve the dependencies which probably uses conda under the hood. Why mention mamba in the comment if this is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters too much here, but off the top of my head conda-lock uses mamba if available so I am guessing that we actually use mamba to generate the lock files ...
The no_openmp build was green in my previous commit: https://dev.azure.com/scikit-learn/d9c6f05f-7f58-4a17-b143-2a4e7ff015af/_build/results?buildId=46441&view=logs&jobId=e6d5b7c0-0dfd-5ddf-13d5-c71bebf56ce2 |
The macOS pylatest_conda_mkl_no_openmp is green https://github.com/scikit-learn/scikit-learn/pull/24373/checks?check_run_id=8208937669 (kind of expected since I only change the comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then, let's merge!
Reference Issues/PRs
Seen in #24363 (comment)