Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI unpin coverage where possible and regenerate lock files #23969

Merged
merged 2 commits into from Jul 21, 2022

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jul 21, 2022

Coverage 6.4 is fork-safe nedbat/coveragepy#1310 (comment) so there is no need to pin coverage=6.2.

I actually kept the pin coverage=6.2 for builds using the conda defaults channel, where coverage 6.4 is not available yet.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The errors in the CI from nightly builds and nogil are not related to the unpinning of coverage.

@thomasjpfan thomasjpfan merged commit c42720e into scikit-learn:main Jul 21, 2022
@lesteve lesteve deleted the unpin-coverage branch July 21, 2022 12:48
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
mathijs02 pushed a commit to mathijs02/scikit-learn that referenced this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants