Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT using pytest-xdist and pin coverage to 6.2 #22311

Merged
merged 4 commits into from
Jan 27, 2022
Merged

MAINT using pytest-xdist and pin coverage to 6.2 #22311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
420c265
MAINT check coverage impact on stalled CI builds
glemaitre Jan 27, 2022
a844b39
add comments regarding pinning
glemaitre Jan 27, 2022
1ad701a
iter
glemaitre Jan 27, 2022
0298092
this should have fail
glemaitre Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_tools/azure/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ python -m pip install $(get_dep threadpoolctl $THREADPOOLCTL_VERSION) \
$(get_dep pytest-xdist $PYTEST_XDIST_VERSION)

if [[ "$COVERAGE" == "true" ]]; then
python -m pip install codecov pytest-cov
python -m pip install codecov pytest-cov coverage==6.2
ogrisel marked this conversation as resolved.
Show resolved Hide resolved
fi

if [[ "$PYTEST_XDIST_VERSION" != "none" ]]; then
Expand Down
2 changes: 1 addition & 1 deletion build_tools/azure/install_win.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if [[ "$PYTEST_XDIST_VERSION" != "none" ]]; then
fi

if [[ "$COVERAGE" == "true" ]]; then
pip install coverage codecov pytest-cov
pip install coverage codecov pytest-cov coverage==6.2
glemaitre marked this conversation as resolved.
Show resolved Hide resolved
fi

python --version
Expand Down
2 changes: 1 addition & 1 deletion build_tools/azure/posix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
MATPLOTLIB_VERSION: 'latest'
PYTEST_VERSION: 'latest'
# Disable pytest-xdist as it can stall builds
PYTEST_XDIST_VERSION: 'none'
PYTEST_XDIST_VERSION: 'latest'
THREADPOOLCTL_VERSION: 'latest'
COVERAGE: 'true'
TEST_DOCSTRINGS: 'false'
Expand Down
2 changes: 1 addition & 1 deletion build_tools/azure/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
SKLEARN_SKIP_NETWORK_TESTS: '1'
PYTEST_VERSION: '5.2.1'
# Disable pytest-xdist as it can stall builds
PYTEST_XDIST_VERSION: 'none'
PYTEST_XDIST_VERSION: 'latest'
TEST_DIR: '$(Agent.WorkFolder)/tmp_folder'
SHOW_SHORT_SUMMARY: 'false'
CPU_COUNT: '2'
Expand Down
2 changes: 1 addition & 1 deletion build_tools/circle/build_test_arm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ mamba install --verbose -y ccache \
setup_ccache

if [[ "$COVERAGE" == "true" ]]; then
mamba install --verbose -y codecov pytest-cov
mamba install --verbose -y codecov pytest-cov coverage==6.2
glemaitre marked this conversation as resolved.
Show resolved Hide resolved
fi

if [[ "$TEST_DOCSTRINGS" == "true" ]]; then
Expand Down