Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI temporary fix for setuptools and distutils in Windows #22049

Merged
merged 2 commits into from
Dec 21, 2021
Merged

CI temporary fix for setuptools and distutils in Windows #22049

merged 2 commits into from
Dec 21, 2021

Conversation

glemaitre
Copy link
Member

Trying to make the CI green

@thomasjpfan
Copy link
Member

thomasjpfan commented Dec 21, 2021 •
edited

I feel like we need to start pinning setuptools like NumPy and SciPy does in pyproject.toml. I suspect our wheel building jobs will also error without SETUPTOOLS_USE_DISTUTILS.

XREF: pypa/setuptools#2372 (comment)
XREF: numpy/numpy#18588 (comment)

@glemaitre
Copy link
Member Author

Yes I will push a [cd build] to see what happens

@glemaitre
Copy link
Member Author

I suspect our wheel building jobs will also error without SETUPTOOLS_USE_DISTUTILS.

At least the conda-forge one

ogrisel
ogrisel approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glemaitre
Copy link
Member Author

Let's see how it fails on the CD

@ogrisel
Copy link
Member

ogrisel commented Dec 21, 2021

Ok so we get the failed with exit status 1158 error on all the Windows builds, whatever the version of Python...

@ogrisel
Copy link
Member

ogrisel commented Dec 21, 2021 •
edited

Maybe pinning "setuptools<0.60" in pyproject.toml is a better workaround for now.

thomasjpfan
thomasjpfan approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this to unblock PRs, and work on wheels in another PR. Wheel building looks to have other issues.

(Scipy 1.7.3 does not have manylinux1 builds while 1.7.0 does)

@hvassard hvassard mentioned this pull request Dec 21, 2021
Merged
2 tasks
@thomasjpfan thomasjpfan merged commit e5cc0b8 into scikit-learn:main Dec 21, 2021
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@glemaitre
CI temporary fix for setuptools and distutils in Windows (scikit-lear…
a049c20 
…n#22049)
glemaitre added a commit that referenced this pull request Dec 25, 2021
@glemaitre
CI temporary fix for setuptools and distutils in Windows (#22049)
24fed55
venkyyuvy pushed a commit to venkyyuvy/scikit-learn that referenced this pull request Jan 1, 2022
@glemaitre @venkyyuvy
CI temporary fix for setuptools and distutils in Windows (scikit-lear…
1c77c93 
…n#22049)
@jeremiedbb jeremiedbb mentioned this pull request Mar 20, 2022
Merged
mathijs02 pushed a commit to mathijs02/scikit-learn that referenced this pull request Dec 27, 2022
@glemaitre
CI temporary fix for setuptools and distutils in Windows (scikit-lear…
a66b764 
…n#22049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glemaitre @thomasjpfan @ogrisel