MAINT workaround for bug in setuptools/pkg_resources #21676
Conversation
| @@ -20,6 +20,9 @@ addopts = | |||
| filterwarnings = | |||
| ignore:the matrix subclass:PendingDeprecationWarning | |||
|
|
|||
| # Workaround for https://github.com/pypa/setuptools/issues/2885 | |||
| ignore::DeprecationWarning:pkg_resources | |||
There was a problem hiding this comment.
| ignore::DeprecationWarning:pkg_resources | |
| ignore:Creating a LegacyVersion has been deprecated:DeprecationWarning |
maybe?
There was a problem hiding this comment.
I think I understand: when CHECK_WARNINGS='true' the default pytest config from setup.cfg no longer applies.
There was a problem hiding this comment.
and indeed when we have -Werror::DeprecationWarning in the commandline, we also need -Wignore:Creating\ a\ LegacyVersion:DeprecationWarning in the commandline. -Wignore::DeprecationWarning:pkg_resources does not work, probably because it does not subsume error::DeprecationWarning in the pytest logic.
|
The setuptools 59.1 release has been yanked (pypa/setuptools#2885 (comment)) so this workaround should not be needed anymore. |
|
Actually by the time the yanking propagates to conda-based distributions, it might be better to apply this workaround. |
|
Edit: my closing / reopening of this PR triggered another Azure pipelines build. Maybe waiting for this to complete is safer. Edit 2: too late, @adrinjalali was too quick ;) |
…learn#21676)" This reverts commit a0b5e1b.
…learn#21676)" (scikit-learn#21723) This reverts commit a0b5e1b.
* MAINT workaround for bug in setuptools/pkg_resources * Additional workakaround for CHECK_WARNINGS commandline
…learn#21676)" (scikit-learn#21723) This reverts commit a0b5e1b.
Workaround for pypa/setuptools#2885
Fixes #21674.