FIX ignore spurious RuntimeWarning in test on macOS M1 machines #21070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in this test can raise: RuntimeWarning: divide by zero encountered in reciprocal but this warning should not be raised. See the upstream report: numpy/numpy#18555 In the mean time, let's ignore those warnings in this test to make it pass and avoid crashing the scikit-learn tests on those systems.
thomasjpfan
reviewed
Sep 25, 2021
There was a problem hiding this comment.
Tested on an M1 laptop and this fix works.
Should this PR be reverted when numpy/numpy#19926 is merged & released?
| # On macOS with a Apple Silicon M1 processor, we can get a spurious | ||
| # RuntimeWarning when executing this code. Let us just filter those | ||
| # warnings out. See: https://github.com/numpy/numpy/issues/18555 | ||
| unwanted = [r for r in unwanted if r.category != RuntimeWarning] |
There was a problem hiding this comment.
This test is kind of flaky with warning_category=None since it catches everything, when I think it wants to focus on the deprecation warning. Maybe we can define unwanted depending on warning_category?
if warning_category is None:
unwanted = [r for r in record if r.category == FutureWarning]
else:
unwanted = [r for r in record if r.category != warning_category]I think this fix will end up to be temporary, so I am okay with leaving the PR as is.
|
I had forgotten about this PR. Turned out that the problem was not limited to M1 and will be fixed in numpy 1.22 so #21396 is a better temporary fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in this test can raise:
but this warning should not be raised. See the upstream report: numpy/numpy#18555
In the mean time, let's ignore those warnings in this test to make it pass and avoid crashing the scikit-learn tests on those systems.