Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRs to include in 1.0.rc2 #21008

Merged
merged 9 commits into from
Sep 14, 2021
Merged

PRs to include in 1.0.rc2 #21008

merged 9 commits into from
Sep 14, 2021

Conversation

adrinjalali
Copy link
Member

This is the list of PRs to be included in the 1.0.RC2, another PR will change the version on the branch. This should not be squashed.

cc @glemaitre @ogrisel

glemaitre and others added 7 commits September 10, 2021 12:25
@glemaitre @jeremiedbb
@ogrisel @adrinjalali
FIX change the meaning of include_boundaries in check_scalar (scikit-…
82c280a 
…learn#20921)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@NicolasHug @adrinjalali
DOC Add whatsnew entry for 20056 (scikit-learn#20966)
fc7425a
@ogrisel @adrinjalali
Fix the stalled linux/arm64 [cd build] jobs on travis (scikit-learn#2…
b9ee87e 
…0958)
@thomasjpfan @adrinjalali
BUG Fixes FunctionTransformer validation in inverse_transform (scikit…
6356747 
…-learn#20961)
@glemaitre @adrinjalali
DOC fix mispelling in whats new (scikit-learn#20974)
c070b88
@glemaitre @adrinjalali
TST solve issues in PyPy (scikit-learn#20978)
559a993 
* TST fix brittle test in pypy for error message

* iter

* Update test_sgd.py

* Update test_sgd.py

* remove pypy3 in PRs
@thomasjpfan @adrinjalali
API Deprecates plot_partial_dependence (scikit-learn#20959)
508cf71 
* API Deprecates plot_partial_dependence

* DOC Adds whats new

* DOC Fixes doc build errors

* CLN Removes feature warning

* CLN Address comments

* DOC Fix docstrings

* TST Skip future warning tests

* DOC Adjust docstrings

* REV Reduce diff

* DOC Adds docstring
@adrinjalali adrinjalali added this to the 1.0 milestone Sep 10, 2021
@adrinjalali adrinjalali mentioned this pull request Sep 10, 2021
Merged
@adrinjalali
Copy link
Member Author

@thomasjpfan what O_o? (https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=32399&view=logs&j=78a0bf4f-79e5-5387-94ec-13e67d216d6e&t=f1857171-4a53-55c7-3ab5-90acfe091baa&l=1018)

FutureWarning: `n_features_in_` is deprecated in 1.0 and will be removed in 1.2.

ogrisel
ogrisel approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for an rc2 to test the conda packages properly.

@ogrisel
Copy link
Member

ogrisel commented Sep 10, 2021 •
edited

FutureWarning: n_features_in_ is deprecated in 1.0 and will be removed in 1.2.

@glemaitre did a fix in main for this one. this is only for the dummy estimators.

Edit: @adrinjalali here it is: #20963

@adrinjalali
Copy link
Member Author

@scikit-learn/core-devs anything else you want in RC2?

@glemaitre
Copy link
Member

If possible, I would like to have this bug fix: #20761
It would need a second review but it would avoid delaying to 1.0.1

@thomasjpfan
Copy link
Member

#21031 for inclusion to make CalibrationDisplay more consistent with the rest of the DisplayAPIs.

@glemaitre @thomasjpfan @adrinjalali
FIX use same API for CalibrationDisplay than other Display (scikit-le…
634b62b 
…arn#21031)

* FIX use same API for CalibrationDisplay than other Display

* Update sklearn/calibration.py

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>

* iter

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@adrinjalali
Copy link
Member Author

adrinjalali commented Sep 14, 2021 •
edited

It would need a second review but it would avoid delaying to 1.0.1

I'd like to avoid having to include those fixes now, otherwise we'd need to include all fixes and would never release.

@adrinjalali adrinjalali merged commit b4edfee into scikit-learn:1.0.X Sep 14, 2021
@adrinjalali adrinjalali deleted the 1.0.rc2 branch September 14, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adrinjalali @ogrisel @glemaitre @thomasjpfan @NicolasHug