Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC add release highlights for 1.0 #20980

Merged
merged 33 commits into from Sep 19, 2021
Merged

DOC add release highlights for 1.0 #20980

merged 33 commits into from Sep 19, 2021

Conversation

adrinjalali
Copy link
Member

Taking a stab at release highlights, checking how it renders.

Closes #20926

@adrinjalali adrinjalali added this to the 1.0 milestone Sep 8, 2021
@adrinjalali
Copy link
Member Author

tagging #20965 for inclusion

TomDLT
TomDLT reviewed Sep 8, 2021
View reviewed changes
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @adrinjalali , I gave it a quick look, this looks great so far

examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
adrinjalali and others added 12 commits September 9, 2021 12:04
@adrinjalali @TomDLT
Update examples/release_highlights/plot_release_highlights_1_0.py
af67279 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali @glemaitre
Update examples/release_highlights/plot_release_highlights_1_0.py
7e91d35 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@adrinjalali @glemaitre
Update examples/release_highlights/plot_release_highlights_1_0.py
8b830f0 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@adrinjalali @glemaitre
Update examples/release_highlights/plot_release_highlights_1_0.py
07cb4d9 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@adrinjalali @TomDLT
Update examples/release_highlights/plot_release_highlights_1_0.py
9b2b4fb 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali @TomDLT
Update examples/release_highlights/plot_release_highlights_1_0.py
da41d0a 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali @TomDLT
Update examples/release_highlights/plot_release_highlights_1_0.py
ce13899 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali @TomDLT
Update examples/release_highlights/plot_release_highlights_1_0.py
0711264 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali @TomDLT
Update examples/release_highlights/plot_release_highlights_1_0.py
5781c75 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali @NicolasHug
Update examples/release_highlights/plot_release_highlights_1_0.py
c2bc93b 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@adrinjalali @NicolasHug
Update examples/release_highlights/plot_release_highlights_1_0.py
e7458f7 
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@adrinjalali
apply more suggestions
58bdcf1
@adrinjalali
Copy link
Member Author

@thomasjpfan do you mind adding a section for feature names related stuff?

lorentzenchr
lorentzenchr approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrinjalali Thanks for the good draft.

examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0.py Outdated Show resolved Hide resolved
@thomasjpfan
Copy link
Member

@thomasjpfan do you mind adding a section for feature names related stuff?

I'll draft it up this weekend.

@thomasjpfan
Copy link
Member

Updated PR with:

  1. 83e55af Adds the feature names part
  2. 28a4174 adjust the file name so that the string parsing works in doc/conf.py.
  3. 6da7088 Address comments from @lorentzenchr

@adrinjalali
Copy link
Member Author

The highlights now render properly (with links to examples). Should we merge?

thomasjpfan
thomasjpfan approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lorentzenchr
lorentzenchr approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some final nitpicks.

examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
examples/release_highlights/plot_release_highlights_1_0_0.py Outdated Show resolved Hide resolved
adrinjalali and others added 11 commits September 19, 2021 12:38
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
ade2804 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
4d9ac61 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
ade63ac 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
d7d6d0e 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
219a586 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
2a11c10 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
8de0767 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
3d7bdcc 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
60e522f 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_0_0.py
97ea98e 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@adrinjalali
cleanup
25cf711
@lorentzenchr lorentzenchr merged commit 6c566da into scikit-learn:main Sep 19, 2021
@adrinjalali adrinjalali deleted the highlights branch September 19, 2021 13:50
adrinjalali added a commit to adrinjalali/scikit-learn that referenced this pull request Sep 20, 2021
@adrinjalali @TomDLT
@glemaitre @NicolasHug @lorentzenchr @thomasjpfan @rth
DOC add release highlights for 1.0 (scikit-learn#20980)
9f0a671 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
DimitriPapadopoulos added a commit to DimitriPapadopoulos/scikit-learn that referenced this pull request Sep 21, 2021
@DimitriPapadopoulos
Fix a few typos from scikit-learn#20980
f708011
DimitriPapadopoulos added a commit to DimitriPapadopoulos/scikit-learn that referenced this pull request Sep 21, 2021
@DimitriPapadopoulos
Fix a few typos from scikit-learn#20980
b8cf1b5
adrinjalali added a commit that referenced this pull request Sep 23, 2021
@adrinjalali @TomDLT
@glemaitre @NicolasHug @lorentzenchr @thomasjpfan @rth
DOC add release highlights for 1.0 (#20980)
b6b6268 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@adrinjalali @TomDLT
@glemaitre @NicolasHug @lorentzenchr @thomasjpfan @rth @samronsin
DOC add release highlights for 1.0 (scikit-learn#20980)
38ab5cb 
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth left review comments

@NicolasHug NicolasHug NicolasHug left review comments

@cmarmo cmarmo cmarmo left review comments

@glemaitre glemaitre glemaitre left review comments

@TomDLT TomDLT TomDLT left review comments

@lucyleeow lucyleeow lucyleeow left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
Documentation No Changelog Needed
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Release highlights for 1.0
9 participants
@adrinjalali @thomasjpfan @rth @NicolasHug @cmarmo @glemaitre @TomDLT @lorentzenchr @lucyleeow