Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Release highlights for version 0.24 #18795

Merged
merged 54 commits into from
Nov 30, 2020

Conversation

cmarmo
Copy link
Member

@cmarmo cmarmo commented Nov 9, 2020

What does this implement/fix? Explain your changes.

Adds release highlights for version 0.24

Any other comments?

This is still very WIP, but I have a list of features I'm planning to highlight: @scikit-learn/core-devs do you mind letting me know if there are some missing or unnecessary? Thanks a lot!
@NicolasHug, successive halving is drafted already, let me know if I'm on the right direction here. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmarmo, I commented below where I noted a few inaccuracies.

SH is really hard to explain, let alone in such a short amount of text. Maybe the safest way here is to copy-paste the first 2 paragraphs of the UG, with some minor subsampling / alterations?

@lorentzenchr
Copy link
Member

New examples are usually not listed in release notes. Could we advertise those a bit more, somewhere?

@lorentzenchr
Copy link
Member

Maybe add SequentialFeatureSelector.

@cmarmo
Copy link
Member Author

cmarmo commented Nov 10, 2020

New examples are usually not listed in release notes. Could we advertise those a bit more, somewhere?

In principle release highlights are linked in the homepage
image
I think this is a good advertising already.

@ogrisel ogrisel added this to the 0.24 milestone Nov 10, 2020
@ogrisel
Copy link
Member

ogrisel commented Nov 10, 2020

I think this is a good advertising already.

I think the point of @lorentzenchr is to link some important, newly introduced examples from the 0.24 release highlight example itself. For instance: https://scikit-learn.org/dev/auto_examples/model_selection/plot_grid_search_stats.html

@cmarmo
Copy link
Member Author

cmarmo commented Nov 10, 2020

I think this is a good advertising already.

I think the point of @lorentzenchr is to link some important, newly introduced examples from the 0.24 release highlight example itself. For instance: https://scikit-learn.org/dev/auto_examples/model_selection/plot_grid_search_stats.html

Sorry I misunderstood... I think a nice solution would be to have a "New" tag like suggested in #16601

@ogrisel
Copy link
Member

ogrisel commented Nov 10, 2020

Sorry I misunderstood... I think a nice solution would be to have a "New" tag like suggested in #16601

Yes, but it would also be worth adding a paragraph /section in the release highlights that lists new or significantly improved, well-developed examples (with a short description and a link).

@cmarmo
Copy link
Member Author

cmarmo commented Nov 12, 2020

@lorentzenchr @ogrisel, I have added a section about documentation improvements using also html meta tags ... this is a suggestion for #16601 also.
I think we can freeze the list as 9 items are already a good pool of novelties. WDYT?

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the PolynomialCountSketch highlight:

@cmarmo cmarmo changed the title [WIP] Release highlights for version 0.24 [MRG] Release highlights for version 0.24 Nov 25, 2020
@cmarmo
Copy link
Member Author

cmarmo commented Nov 25, 2020

I'm wondering if we can add in some way the information about the new build system via github actions directly in the scikit-learn repo.

@jeremiedbb
Copy link
Member

I'm wondering if we can add in some way the information about the new build system via github actions directly in the scikit-learn repo.

I don't think so. It's not a new feature for the users. The real impact is for the maintainers.

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Nov 25, 2020 via email

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments. I still need to give it a full review.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions:

@ogrisel
Copy link
Member

ogrisel commented Nov 26, 2020

Do we really need to specify "when combined with early stopping"? The benefits of the native handling seem unrelated to ES to me

Ok. Let's keep it simple then.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cmarmo, probably last comments from me, LGTM when addressed.

The current highlights run in about 48 seconds, which is quite long compared to the previous ones. Any chance we can reduce the timing a bit? Perhaps we can use LogisticRegression instead of KNeighborsClassifier with SFS? Maybe the SH and ICE parts are slow too, I haven't run it.

doc/glossary.rst Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well (once remaining comments are addressed).

doc/glossary.rst Outdated Show resolved Hide resolved
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@cmarmo
Copy link
Member Author

cmarmo commented Nov 30, 2020

@NicolasHug feel free to finalize this PR as you prefer: this will move things faster wrt some new back and forth about my copied and pasted text.

@NicolasHug
Copy link
Member

I've pushed my remaining comments. I'll take a last look at the rendered html and will merge when green.

@NicolasHug NicolasHug changed the title [MRG] Release highlights for version 0.24 DOC Release highlights for version 0.24 Nov 30, 2020
@NicolasHug NicolasHug merged commit 76e82ba into scikit-learn:master Nov 30, 2020
@cmarmo cmarmo deleted the release-highlights-0.24 branch November 30, 2020 19:24
@glemaitre
Copy link
Member

do we have some broken stuff here

@glemaitre
Copy link
Member

Oh no, just some git checkout errors due merging in master before the build starts :)

@NicolasHug
Copy link
Member

Should be fine, I merged without waiting for all checks to finish because I only made minor doc changes in the last commits

@ogrisel
Copy link
Member

ogrisel commented Nov 30, 2020

Thanks @Chiara and @NicolasHug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants