[MRG] DOC Add example about interpretation of coefficients of linear models #15706

cmarmo · 2019-11-22T14:25:15Z

What does this implement/fix? Explain your changes.

This PR adds an example in the inspection section, about the interpretation of coefficients in linear models.

Any other comments?

The example makes use of the seaborn package. I've added it to the build on Circle CI. If there is no consensus about that, I will re-write the plot in matplotlib.

Steps to finalise this PR

Clarify marginal and conditional semantic
Add Scaler preprocessing for numerical variables and compare
Address unresolved comments

cmarmo · 2019-11-25T13:19:22Z

@glemaitre , I think that the build on Azure failed for reasons having nothing to do with my changes...

jnothman · 2019-11-25T19:27:24Z

Re the failure see #15713

jeremiedbb · 2019-11-28T13:14:42Z

It has been fixed on conda-forge side. Should be green now

NicolasHug

Thanks @cmarmo , this is a nice addition

Made a bunch of comments but mostly looks good.

To avoid data leaks, I think we need to split the dataset before doing any sort of exploration.

build_tools/circle/build_doc.sh

examples/inspection/plot_linear_model_coefficient_interpretation.py

glemaitre

A first pass on the example.

examples/inspection/plot_linear_model_coefficient_interpretation.py

…on.py Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

examples/inspection/plot_linear_model_coefficient_interpretation.py

…on.py Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>

examples/inspection/plot_linear_model_coefficient_interpretation.py

glemaitre · 2020-03-10T17:18:13Z

Apart of these glitches of rendering, LGTM

glemaitre · 2020-03-10T17:20:34Z

Oh just a last thing, we should mention in the README.rst and install.rst that seaborn will be required as well for the example (next to the occurrence of matplotlib)

examples/inspection/plot_linear_model_coefficient_interpretation.py

glemaitre · 2020-03-10T18:26:23Z

I will merge when it is green.

jnothman · 2020-03-10T22:59:44Z

Thank you @cmarmo for a wonderful addition to the documentation

…models (scikit-learn#15706) Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

cmarmo added 12 commits November 18, 2019 15:58

Add example on interpretation of linear model coefficients.

a8fa2c4

Add coefficient instability.

407439c

Merge branch 'master' into lincoeffinterpexample

c75ce26

Working on coefficient stability

e70b5aa

Merge branch 'master' into lincoeffinterpexample

9ace87c

Fix plot properties.

e5eb09b

Rearrange plot. Introduce more dataset inspection.

dc3fca8

Fix lint issues.

8600507

Fix overindentation.

159d028

Fix underindentation :) .

43125fa

Add seaborn in build doc conda environment.

9df008a

Remove matplotlib logger (too recent for build doc-min-dependencies?).

da23762

cmarmo changed the title ~~DOC Add example about interpretation of coefficients of linear models~~ [WIP] DOC Add example about interpretation of coefficients of linear models Nov 22, 2019

cmarmo added 3 commits November 25, 2019 13:20

Change boxenplot to boxplot to avoid warnings.

c875e4b

Remove debug lines.

6dcd6bc

Fix 'Invalid rgb arg C0' Error for doc min dependencies build.

9bdff51

cmarmo changed the title ~~[WIP] DOC Add example about interpretation of coefficients of linear models~~ [MRG] DOC Add example about interpretation of coefficients of linear models Nov 25, 2019

cmarmo added 2 commits November 28, 2019 14:22

Merge branch 'master' into lincoeffinterpexample

8f93d95

Trigger CI

d152cd1

NicolasHug reviewed Dec 3, 2019

View reviewed changes

glemaitre reviewed Dec 3, 2019

View reviewed changes

cmarmo and others added 6 commits December 3, 2019 21:20

Update examples/inspection/plot_linear_model_coefficient_interpretati…

46ada5d

…on.py Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

Update examples/inspection/plot_linear_model_coefficient_interpretati…

7bfd0c7

…on.py Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

Update examples/inspection/plot_linear_model_coefficient_interpretati…

c023cff

…on.py Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>

Merge branch 'master' into lincoeffinterpexample

a29fa69

Add seaborn in doc dependencies, fix easy comments.

64380b2

Merge branch 'master' into lincoeffinterpexample

4123452

NicolasHug mentioned this pull request Feb 29, 2020

Tags for the example gallery? #16601

Open

cmarmo mentioned this pull request Mar 2, 2020

ENH Add check for non binary variables in OneHotEncoder. #16585

Merged

glemaitre reviewed Mar 10, 2020

View reviewed changes

Merge branch 'master' into lincoeffinterpexample

ead7a8c

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

cmarmo and others added 3 commits March 10, 2020 15:19

Fix OneHotEncoder. Address last comments.

fcff805

Update examples/inspection/plot_linear_model_coefficient_interpretati…

8e11386

…on.py Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>

Update examples/inspection/plot_linear_model_coefficient_interpretati…

2e89d9c

…on.py Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

glemaitre approved these changes Mar 10, 2020

View reviewed changes

cmarmo added 3 commits March 10, 2020 18:45

Address comments.

d07181d

Add dataframe css.

4f97c06

Fix lint errors.

a2f29bc

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

glemaitre reviewed Mar 10, 2020

View reviewed changes

examples/inspection/plot_linear_model_coefficient_interpretation.py Outdated Show resolved Hide resolved

Update plot_linear_model_coefficient_interpretation.py

2d2f6df

PEP8

ffd06d7

jnothman merged commit e9340e3 into scikit-learn:master Mar 10, 2020

cmarmo deleted the lincoeffinterpexample branch March 11, 2020 10:34

cmarmo mentioned this pull request Mar 12, 2020

DOC: wording in linear model interpretation #16680

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] DOC Add example about interpretation of coefficients of linear models #15706

[MRG] DOC Add example about interpretation of coefficients of linear models #15706

cmarmo commented Nov 22, 2019 •

edited

cmarmo commented Nov 25, 2019

jnothman commented Nov 25, 2019 via email

jeremiedbb commented Nov 28, 2019

NicolasHug left a comment

glemaitre left a comment

glemaitre commented Mar 10, 2020

glemaitre commented Mar 10, 2020

glemaitre commented Mar 10, 2020

jnothman commented Mar 10, 2020

[MRG] DOC Add example about interpretation of coefficients of linear models #15706

[MRG] DOC Add example about interpretation of coefficients of linear models #15706

Conversation

cmarmo commented Nov 22, 2019 • edited

What does this implement/fix? Explain your changes.

Any other comments?

Steps to finalise this PR

cmarmo commented Nov 25, 2019

jnothman commented Nov 25, 2019 via email

jeremiedbb commented Nov 28, 2019

NicolasHug left a comment

Choose a reason for hiding this comment

glemaitre left a comment

Choose a reason for hiding this comment

glemaitre commented Mar 10, 2020

glemaitre commented Mar 10, 2020

glemaitre commented Mar 10, 2020

jnothman commented Mar 10, 2020

cmarmo commented Nov 22, 2019 •

edited