Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more on LARS (we're getting there) #2

Merged
9 commits merged into from Sep 2, 2010
Merged

Conversation

agramfort
Copy link
Member

No description provided.

@ogrisel
Copy link
Member

ogrisel commented Sep 1, 2010

+1 for the merge

@ogrisel
Copy link
Member

ogrisel commented Sep 1, 2010

btw, the new pull request UI is great: we should use it more often!

ogrisel referenced this pull request in ogrisel/scikit-learn May 30, 2011
WeatherGod referenced this pull request in WeatherGod/scikit-learn Jun 7, 2011
agramfort referenced this pull request in agramfort/scikit-learn Jun 22, 2011
mblondel added a commit that referenced this pull request Aug 24, 2011
amueller referenced this pull request in amueller/scikit-learn Dec 21, 2011
ndawe referenced this pull request in ndawe/scikit-learn Jan 2, 2012
Update random forest example to demo n_jobs=2
wslihgt pushed a commit to wslihgt/scikit-learn that referenced this pull request Mar 10, 2012
@pprett pprett mentioned this pull request Jul 16, 2012
sergeyf added a commit to sergeyf/scikit-learn that referenced this pull request Nov 7, 2016
yc2311 pushed a commit to nyu-ossd-s19/scikit-learn that referenced this pull request Apr 21, 2019
xhluca referenced this pull request in xhluca/scikit-learn Apr 28, 2019
…13243)

* Remove unused code

* Squash all the PR 9040 commits

initial PR commit

seq_dataset.pyx generated from template

seq_dataset.pyx generated from template #2

rename variables

fused types consistency test for seq_dataset

a

sklearn/utils/tests/test_seq_dataset.py

new if statement

add doc

sklearn/utils/seq_dataset.pyx.tp

minor changes

minor changes

typo fix

check numeric accuracy only up 5th decimal

Address oliver's request for changing test name

add test for make_dataset and rename a variable in test_seq_dataset

* FIX tests

* TST more numerically stable test_sgd.test_tol_parameter

* Added benchmarks to compare SAGA 32b and 64b

* Fixing gael's comments

* fix

* solve some issues

* PEP8

* Address lesteve comments

* fix merging

* avoid using assert_equal

* use all_close

* use explicit ArrayDataset64 and CSRDataset64

* fix: remove unused import

* Use parametrized to cover ArrayDaset-CSRDataset-32-64 matrix

* for consistency use 32 first then 64 + add 64 suffix to variables

* it would be cool if this worked !!!

* more verbose version

* revert SGD changes as much as possible.

* Add solvers back to bench_saga

* make 64 explicit in the naming

* remove checking native python type + add comparison between 32 64

* Add whatsnew with everyone with commits

* simplify a bit the testing

* simplify the parametrize

* update whatsnew

* fix pep8
xhluca referenced this pull request in xhluca/scikit-learn Apr 28, 2019
* initial commit

* used random class

* fixed failing testcases, reverted __init__.py

* fixed failing testcases #2
- passed rng as parameter to ParameterSampler class
- changed seed from 0 to 42 (as original)

* fixed failing testcases #2
- passed rng as parameter to SparseRandomProjection class

* fixed failing testcases scikit-learn#4
- passed rng as parameter to GaussianRandomProjection class

* fixed failing test case because of flake 8
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
…13243)

* Remove unused code

* Squash all the PR 9040 commits

initial PR commit

seq_dataset.pyx generated from template

seq_dataset.pyx generated from template scikit-learn#2

rename variables

fused types consistency test for seq_dataset

a

sklearn/utils/tests/test_seq_dataset.py

new if statement

add doc

sklearn/utils/seq_dataset.pyx.tp

minor changes

minor changes

typo fix

check numeric accuracy only up 5th decimal

Address oliver's request for changing test name

add test for make_dataset and rename a variable in test_seq_dataset

* FIX tests

* TST more numerically stable test_sgd.test_tol_parameter

* Added benchmarks to compare SAGA 32b and 64b

* Fixing gael's comments

* fix

* solve some issues

* PEP8

* Address lesteve comments

* fix merging

* avoid using assert_equal

* use all_close

* use explicit ArrayDataset64 and CSRDataset64

* fix: remove unused import

* Use parametrized to cover ArrayDaset-CSRDataset-32-64 matrix

* for consistency use 32 first then 64 + add 64 suffix to variables

* it would be cool if this worked !!!

* more verbose version

* revert SGD changes as much as possible.

* Add solvers back to bench_saga

* make 64 explicit in the naming

* remove checking native python type + add comparison between 32 64

* Add whatsnew with everyone with commits

* simplify a bit the testing

* simplify the parametrize

* update whatsnew

* fix pep8
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
* initial commit

* used random class

* fixed failing testcases, reverted __init__.py

* fixed failing testcases scikit-learn#2
- passed rng as parameter to ParameterSampler class
- changed seed from 0 to 42 (as original)

* fixed failing testcases scikit-learn#2
- passed rng as parameter to SparseRandomProjection class

* fixed failing testcases scikit-learn#4
- passed rng as parameter to GaussianRandomProjection class

* fixed failing test case because of flake 8
alekslovesdata pushed a commit to alekslovesdata/scikit-learn that referenced this pull request Nov 2, 2019
ericpre pushed a commit to ericpre/scikit-learn that referenced this pull request Jun 23, 2020
Varimax PR: address review comments
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Jul 18, 2020
agramfort pushed a commit that referenced this pull request Aug 16, 2020
…#10591)

* Initial add DET curve to classification metrics

* Add DET to exports

* Fix DET-curve doctest errors

- Sample snippet in  model_evaluation documentation was outdated.

* Clarify wording in DET-curve computation

- Align to the wording of ranking module to make it consistent.
- Add correct describtion of input and outputs.
- Update and fix non-existent links

* Beautify DET curve documentation source

- Limit line length to 80 characters.

* Expand DET curve documentation

- Add an example plot to show difference between ROC and DET curves.
- Expand Usage Note section with background information and properties
of DET curves.

* Update DET-curve documentation

- Fix typos and some grammar improvements.
- Use named references to avoid potential conflicts with other sections.
- Remove unneeded references and improved existing ones by using e.g.
using versioned links.

* Select relevant DET points using slice object

* Remove some dubiety from DET curve doc-string

* Add DET curve contributors

* Add tests for DET curves

* Streamline DET test by using parametrization

* Increase verbosity of DET curve error handling

- Explicitly sanity check input before computing a DET curve.
- Add test for perfect scores.
- Adapt indentation style to match the test module.

* Add reference for DET curves in invariance test

* Add automated invariance checks for DET curves

* Resolve merge artifacts

* Make doctest happy

* Fix whitespaces for doctest

* Revert unintended whitespace changes

* Revert unintended white space changes #2

* Fix typos and grammar

* Fix white space in doc

* Streamline test code

* Remove rebase artifacts

* Fix PR link in doc

* Fix test_ranking

* Fix rebase errors

* Fix import

* Bring back newlines

- Swallowed by copy/paste

* Remove uncited ref link

* Remove matplotlib deprecation warning

* Bring back hidden reference

* Add motivation to DET example

* Fix lint

* Add citation

* Use modern matplotlib API

Co-authored-by: Jeremy Karnowski <jeremy.karnowski@gmail.com>
Co-authored-by: Julien Cornebise <julien@cornebise.com>
Co-authored-by: Daniel Mohns <daniel.mohns@zenguard.org>
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
…scikit-learn#10591)

* Initial add DET curve to classification metrics

* Add DET to exports

* Fix DET-curve doctest errors

- Sample snippet in  model_evaluation documentation was outdated.

* Clarify wording in DET-curve computation

- Align to the wording of ranking module to make it consistent.
- Add correct describtion of input and outputs.
- Update and fix non-existent links

* Beautify DET curve documentation source

- Limit line length to 80 characters.

* Expand DET curve documentation

- Add an example plot to show difference between ROC and DET curves.
- Expand Usage Note section with background information and properties
of DET curves.

* Update DET-curve documentation

- Fix typos and some grammar improvements.
- Use named references to avoid potential conflicts with other sections.
- Remove unneeded references and improved existing ones by using e.g.
using versioned links.

* Select relevant DET points using slice object

* Remove some dubiety from DET curve doc-string

* Add DET curve contributors

* Add tests for DET curves

* Streamline DET test by using parametrization

* Increase verbosity of DET curve error handling

- Explicitly sanity check input before computing a DET curve.
- Add test for perfect scores.
- Adapt indentation style to match the test module.

* Add reference for DET curves in invariance test

* Add automated invariance checks for DET curves

* Resolve merge artifacts

* Make doctest happy

* Fix whitespaces for doctest

* Revert unintended whitespace changes

* Revert unintended white space changes scikit-learn#2

* Fix typos and grammar

* Fix white space in doc

* Streamline test code

* Remove rebase artifacts

* Fix PR link in doc

* Fix test_ranking

* Fix rebase errors

* Fix import

* Bring back newlines

- Swallowed by copy/paste

* Remove uncited ref link

* Remove matplotlib deprecation warning

* Bring back hidden reference

* Add motivation to DET example

* Fix lint

* Add citation

* Use modern matplotlib API

Co-authored-by: Jeremy Karnowski <jeremy.karnowski@gmail.com>
Co-authored-by: Julien Cornebise <julien@cornebise.com>
Co-authored-by: Daniel Mohns <daniel.mohns@zenguard.org>
prismdata pushed a commit to prismdata/scikit-learn that referenced this pull request Oct 28, 2020
prismdata pushed a commit to prismdata/scikit-learn that referenced this pull request Oct 28, 2020
Merge pull request scikit-learn#2 from dataignitelab/master
prismdata added a commit to prismdata/scikit-learn that referenced this pull request Oct 28, 2020
hongshaoyang pushed a commit to hongshaoyang/scikit-learn that referenced this pull request Nov 10, 2020
Merging changes from the main repository
efiegel added a commit to efiegel/scikit-learn that referenced this pull request Nov 25, 2020
@yoni2k yoni2k mentioned this pull request Jul 18, 2021
mbatoul pushed a commit to mbatoul/scikit-learn that referenced this pull request Aug 3, 2021
…cython-oop

ParallelReduction class hierarchy (POC for scikit-learn#20254)
Micky774 referenced this pull request in Micky774/scikit-learn Feb 15, 2022
Micky774 referenced this pull request in Micky774/scikit-learn May 25, 2022
deprecation warning for negative ndcg
Vincent-Maladiere added a commit to Vincent-Maladiere/scikit-learn that referenced this pull request Aug 3, 2022
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
LilianBoulard pushed a commit to LilianBoulard/scikit-learn that referenced this pull request Jun 21, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants