FEA add PredictionErrorDisplay

[glemaitre]

Add a PredictionErrorDisplay which is useful when dealing with regression.

Edit: Partially addresses #16608.

[NicolasHug]

i'm getting baited into reviewing this but it doesn't seem finished yet... mark as WIP @glemaitre ? ;)

[glemaitre]

Ups sorry. This is WIP :)

[glemaitre]

You can have a look at the API thought. I change examples and I am writing proper test now that I did my example-based development :)

[glemaitre]

@NicolasHug @thomasjpfan I think the PR is ready to get some attention.
Open to any suggestion regarding the API

[NicolasHug]

Thanks @glemaitre,

I only took a very brief look but my impression is that this might be a bit too high-level for scikit-learn.

My understanding of our goal with the plotting utilities is that we allow users to i) compute complicated stuff like PDPs and ii) update the plot styles without having to re-compute the results every time.

It seems that error plots are really just a matter of calling predict and scatter so it's already quite simple.

Just my personal thoughts, no strong opinion anyway

[glemaitre]

It seems that error plots are really just a matter of calling predict and scatter so it's already quite simple.

I agree with these statements. Basically, I wanted my arguments were the following:

• it is a useful plot that you want to use often in teaching (we need to it during developing our MOOC) or even in practice.
• the predict and scatter are actually the easy part. What I most dislike with some plots that I saw around: (i) the wrong diagonal is shown and (ii) the aspect ratio of the plot is not squared.

So I agree that this is more of a convenience function.

[jnothman]

And I like its convenience! I am not sure we need to limit our plotting utilities to things that are difficult to achieve without.

[glemaitre]

I addressed the issue pointed out by @ogrisel

[lorentzenchr]

A partial review. Short on time atm.

[ogrisel]

I think that using kind="residuals" as the default is indeed a good idea because the class name PredictionErrorDisplay is about "prediction error" which better "residuals vs predicted" than "actual vs predicted".

[ogrisel]

More feedback.

Once this and @lorentzenchr's review comments are addressed, LGTM.

[ogrisel]

Final pass. Other than that and the previous suggestion, LGTM.

[jeremiedbb]

Let's go !

We can still improve some wordings later if needed.

Thanks @glemaitre !