Skip to content

Commit

Permalink
CI Remove Windows 32 bit support (#24627)
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasjpfan authored and glemaitre committed Oct 26, 2022
1 parent 822622c commit 31c226e
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 115 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/wheels.yml
Expand Up @@ -64,16 +64,6 @@ jobs:
python: 311
platform_id: win_amd64

# Window 32 bit
- os: windows-latest
python: 38
bitness: 32
platform_id: win32
- os: windows-latest
python: 39
bitness: 32
platform_id: win32

# Linux 64 bit manylinux2014
- os: ubuntu-latest
python: 38
Expand Down
6 changes: 0 additions & 6 deletions azure-pipelines.yml
Expand Up @@ -279,9 +279,3 @@ jobs:
CHECK_WARNINGS: 'true'
COVERAGE: 'true'
SKLEARN_TESTS_GLOBAL_RANDOM_SEED: '7' # non-default seed
py38_pip_openblas_32bit:
DISTRIB: 'pip-windows'
PYTHON_VERSION: '3.8'
PYTHON_ARCH: '32'
LOCK_FILE: ./build_tools/azure/py38_pip_openblas_32bit_lock.txt
SKLEARN_TESTS_GLOBAL_RANDOM_SEED: '8' # non-default seed
49 changes: 0 additions & 49 deletions build_tools/azure/py38_pip_openblas_32bit_lock.txt

This file was deleted.

12 changes: 0 additions & 12 deletions build_tools/azure/py38_pip_openblas_32bit_requirements.txt

This file was deleted.

2 changes: 0 additions & 2 deletions build_tools/azure/test_script.sh
Expand Up @@ -9,8 +9,6 @@ if [[ "$DISTRIB" =~ ^conda.* ]]; then
source activate $VIRTUALENV
elif [[ "$DISTRIB" == "ubuntu" || "$DISTRIB" == "debian-32" || "$DISTRIB" == "pip-nogil" ]]; then
source $VIRTUALENV/bin/activate
elif [[ "$DISTRIB" == "pip-windows" ]]; then
source $VIRTUALENV/Scripts/activate
fi

if [[ "$BUILD_WITH_ICC" == "true" ]]; then
Expand Down
26 changes: 9 additions & 17 deletions build_tools/github/test_windows_wheels.sh
Expand Up @@ -5,21 +5,13 @@ set -x

PYTHON_VERSION=$1

if [[ "$BITNESS" == "32" ]]; then
# 32-bit architectures use the regular
# test command (outside of the minimal Docker container)
cp $CONFTEST_PATH $CONFTEST_NAME
python -c "import sklearn; sklearn.show_versions()"
pytest --pyargs sklearn
else
docker container run \
--rm scikit-learn/minimal-windows \
powershell -Command "python -c 'import sklearn; sklearn.show_versions()'"
docker container run \
--rm scikit-learn/minimal-windows \
powershell -Command "python -c 'import sklearn; sklearn.show_versions()'"

docker container run \
-e SKLEARN_SKIP_NETWORK_TESTS=1 \
-e OMP_NUM_THREADS=2 \
-e OPENBLAS_NUM_THREADS=2 \
--rm scikit-learn/minimal-windows \
powershell -Command "pytest --pyargs sklearn"
fi
docker container run \
-e SKLEARN_SKIP_NETWORK_TESTS=1 \
-e OMP_NUM_THREADS=2 \
-e OPENBLAS_NUM_THREADS=2 \
--rm scikit-learn/minimal-windows \
powershell -Command "pytest --pyargs sklearn"
19 changes: 0 additions & 19 deletions build_tools/update_environments_and_lock_files.py
Expand Up @@ -314,25 +314,6 @@ def remove_from(alist, to_remove):
# pip-compile
"python_version": "3.8.5",
},
{
"build_name": "py38_pip_openblas_32bit",
"folder": "build_tools/azure",
"pip_dependencies": [
"numpy",
"scipy",
"cython",
"joblib",
"threadpoolctl",
"pytest",
"pytest-xdist",
"pillow",
"wheel",
],
# The Windows 32bit build use 3.8.10. No cross-compilation support for
# pip-compile, we are going to assume the pip lock file on a Linux
# 64bit machine gives appropriate versions
"python_version": "3.8.10",
},
]


Expand Down

0 comments on commit 31c226e

Please sign in to comment.