Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 create citations using GitHub #442

Merged
merged 12 commits into from
May 22, 2024

Conversation

LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented May 14, 2024

Description

This pull request introduces the addition of citation details to the MAPIE project by including a CITATIONS.cff file. The goal is to facilitate proper citation of MAPIE in academic and professional work by providing a standardized citation format. This change addresses the issue raised regarding the beneficial use of citations directly from the GitHub features. The CITATIONS.cff file includes author details, software title, version, release date, URL, and a preferred citation format.

Fixes #400.

Type of change:

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Verified that the CITATIONS.cff file is properly formatted and recognized by GitHub
  • Ensured the citation information is correct and matches the required format

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis linked an issue May 14, 2024 that may be closed by this pull request
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, which will enable the project to be more widely cited.

Is it also possible to add a citation at the end of the readme? (https://github.com/scikit-learn/scikit-learn?tab=readme-ov-file#citation)

Comment on lines +24 to +26
doi: "10.48550/arXiv.2207.12274"
journal: "arXiv preprint arXiv:2207.12274"
title: "MAPIE: an open-source library for distribution-free uncertainty quantification"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to quote the paper presented to COPA (as a replacement or in addition)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remind me the link to this paper? My only concern is that this paper also presented a new insight and was not a general overview of the library.

What do you think @vincentblot28 ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must add the COPA paper as we also present MAPIE in it. https://proceedings.mlr.press/v204/cordier23a/cordier23a.pdf

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (2b156ce).
Report is 362 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #442    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        41     +2     
  Lines         4616      4907   +291     
  Branches       487       523    +36     
==========================================
+ Hits          4616      4907   +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes. Once again, these are just a few harmonised changes. At the same time, I don't understand why we don't see all the citation information in the "Cite the repository" function...

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
LacombeLouis and others added 5 commits May 21, 2024 11:04
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's merge them!

@LacombeLouis LacombeLouis merged commit 44afae4 into master May 22, 2024
8 checks passed
@LacombeLouis LacombeLouis deleted the 400-create-citations-using-github branch June 4, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create citations using GitHub
4 participants