Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0 #7245

Merged
merged 4 commits into from Nov 24, 2023
Merged

Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0 #7245

merged 4 commits into from Nov 24, 2023

Conversation

sitic
Copy link
Contributor

@sitic sitic commented Nov 20, 2023

Description

Pillow release 10.1.0 broke imageio, the new imageio release 2.33.0 fixes the issue (upstream fix).

Require imageio>=2.33 and revert the hotfix Pillow pin.

Closes #7207
Reverts #7208

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically:

Update imageio to fix Pillow incompatibility

@sitic
Revert "Pin Pillow until incompatibility with imageio is fixed. (scik…
beb6c22 
…it-image#7208)"

This reverts commit e6cb9a9.
@sitic
Require imageio>=2.33 to fix incompatibility with Pillow>=10.1.0
0124a61 
Require the new imageio release 2.33.0 which fixes the incompatibility with Pillow>=10.1.0.

fixes scikit-image#7207
reverts scikit-image#7208
@mkcor mkcor added the 🔧 type: Maintenance Refactoring and maintenance of internals label Nov 20, 2023
@sitic
Copy link
Contributor Author

sitic commented Nov 21, 2023

The min requirement tests are failing because the new imageio tries to use PIL.GifImagePlugin.LOADING_STRATEGY, which is only available for pillow>=9.1.0, but the min requirements tests use Pillow==9.0.1.

I've filed an imageio bug report

@mkcor
Copy link
Member

mkcor commented Nov 22, 2023

Thanks for looking into this, @sitic!

@stefanv do we want to wait for an upstream fix or pin

pillow>=9.1.0,<10.1.0

in requirements/default.txt?

@stefanv
Copy link
Member

stefanv commented Nov 22, 2023

Do you mean:

pillow>=9.1.0

? That seems fine.

@mkcor
Copy link
Member

mkcor commented Nov 23, 2023

Do you mean:

pillow>=9.1.0

? That seems fine.

Oops, yes, sorry! @sitic do you mind updating the PR accordingly?

jarrodmillman
jarrodmillman requested changes Nov 24, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
requirements/default.txt Outdated Show resolved Hide resolved
mkcor
mkcor approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jarrodmillman jarrodmillman merged commit 4212f02 into scikit-image:main Nov 24, 2023
16 of 22 checks passed
@stefanv stefanv added this to the 0.23 milestone Nov 24, 2023
@sitic sitic deleted the pillow branch December 13, 2023 00:19
@lagru lagru mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanv stefanv stefanv approved these changes

@jarrodmillman jarrodmillman jarrodmillman approved these changes

@mkcor mkcor mkcor approved these changes

Assignees
No one assigned
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.23
Development

Successfully merging this pull request may close these issues.

Incompatibility between pillow 10.1.0 and imageio<=2.31.5 breaks roundtrip test
4 participants
@sitic @mkcor @stefanv @jarrodmillman