Block sphinx versions for which links from search engine are broken #4910
Conversation
sciunto
changed the title
|
@emmanuelle Would you like to try to reproduce the build failure I have with sphinx==3.2.0 please? We need to report if it can be reproduced. |
grlee77
changed the title
grlee77
changed the title
|
I'm sure no insensitivity was intended in this case, but I modified the PR title to be in line with the recommendations made in a recent discussion at SciPy: scipy/scipy#12446 (comment). |
|
thanks @grlee77 I remember I read a blogpost along this line for like master/slave. I think I would have the reflex easily in my mother tongue, in english it might take longer, but I'll make the effort. Thanks for raising this again. |
|
@sciunto I tested locally both with sphinx 3.2.0 and sphinx 3.2.1. I could not reproduce the build problem and the search was working correctly. Did you try in a fresh environment? Also I'm not sure why you mention the links are broken on CI? |
|
I think we can give it a try with 3.2.1 |
|
@emmanuelle Here is what I meant: click on one of the links from this query: https://216-2014929-gh.circle-artifacts.com/0/doc/build/html/search.html?q=threshold&check_keywords=yes&area=default You will obtain "Artifact not found". |
|
ok I understand. So yes, the new versions still have the problem :-(. |
sciunto
force-pushed
the
sphinx_ver_blacklist
branch
from
ba8fe96
to
5d13520
Compare
requirements/docs.txt
Outdated
| sphinx-gallery>=0.7.0 | ||
| numpydoc>=1.0 | ||
| sphinx>=1.8,!=3.0.0,!=3.0.1,!=3.0.2,!=3.0.3,!=3.0.4 | ||
| numpydoc>=0.9 |
There was a problem hiding this comment.
Is there a reason for these changes here?
There was a problem hiding this comment.
numpydoc and sphinx-gallery that is
There was a problem hiding this comment.
No, I screwed up my rebase.
There was a problem hiding this comment.
yea.... that is always annoying.
There was a problem hiding this comment.
My goal over here is to build the doc with the last sphinx version, and if it appears to have broken links, to open a ticket upstream. I have no clue on this issue.
|
is this ready now? |
Description
Attempt to close #4647
-> need to check that the search engine is working for sphinx>=3.1.0
3.0.x
links are broken
3.1.0
Failure due to sphinx-doc/sphinx#7802
>=3.1.1
not checked yet
3.2.0
On my computer, with sphinx==3.2.0 (4 days ago), I have
But build is successful on circle-ci... however, the links are still broken.