Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error handling to prevent crash #15

Merged
merged 5 commits into from Mar 9, 2022
Merged

feat: add error handling to prevent crash #15

merged 5 commits into from Mar 9, 2022

Conversation

amangoel185
Copy link
Collaborator

henryiii
henryiii reviewed Mar 9, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@henryiii
Copy link
Member

henryiii commented Mar 9, 2022

This is good for now. If we could get this inside a scroll view, then it would be better and we could avoid the height problem, but it's going tricky since we can't render the plot until we know the size, so at that point we are already set into the path of rendering it out.

@henryiii henryiii merged commit b9359ce into scikit-hep:main Mar 9, 2022
@amangoel185
Copy link
Collaborator Author

In reference to #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amangoel185 @henryiii