Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New schema for HS3 Support #2397

Draft
wants to merge 5 commits into
base: feat/updateJSONSchemaDraft
Choose a base branch
from

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Dec 8, 2023

Runtime validations:

  • check that staterror is only defined once per sample
  • check that if staterror is defined, that the sample has defined errors
  • check that contents and errors have the same shape if errors is defined
  • check that likelihoods.distributions has same shape as likelihoods.datasets
  • check that measurements.likelihood points to a valid likelihood
  • check that measurements.domains points to a valid domain
  • check that measurements.inits points to a valid init
  • made modifier data optional (in cases where it was null)

Accepted Defaults:

  • axes has min=0, max=1 (or edges = [0, 1])
  • parameter/parameters is just the name of the parameter(s)
  • staterror data is moved to the sample errors

To Dos:

References:

Pull Request Description

Please first read CONTRIBUTING.md.

Please describe the purpose of this pull request in some detail and what the specific feature being added will do. Reference and link to any relevant issues or pull requests (such as the issue in which this feature was first suggested).

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

@kratsg kratsg changed the base branch from main to feat/updateJSONSchemaDraft December 8, 2023 11:21
Comment on lines +81 to +91
"parameter": {
"type": "object",
"properties": {
"name": { "type": "string" },
"auxdata": { "type": "array", "items": {"type": "number"}, "minItems": 1 },
"factors": { "type": "array", "items": {"type": "number"}, "minItems": 1 },
"sigmas": { "type": "array", "items": {"type": "number"}, "minItems": 1}
},
"required": ["name"],
"additionalProperties": false
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the object that goes into parameter_points in the current HS3 draft? I don't quite follow how to map this to the document. I started looking at this as I as wondering if the format would allow to conveniently distinguish between initial parameter values for the purpose of minimization starting point and default values for the purpose of dataset generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple staterror modifiers per sample and channel, round trips and duplicate modifiers
2 participants