Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow failing toys #2128

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Allow failing toys #2128

wants to merge 2 commits into from

Conversation

lukasheinrich
Copy link
Contributor

@lukasheinrich lukasheinrich commented Mar 3, 2023

Description

Resolves #1427

I tried to implement some basic checks for handling toys as in Issue #1427

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

@lukasheinrich lukasheinrich changed the title [WIP] first attempt on toy handling [WIP] feat: allow failing toys Mar 3, 2023
@matthewfeickert matthewfeickert added the feat/enhancement New feature or request label Mar 3, 2023
@matthewfeickert matthewfeickert changed the title [WIP] feat: allow failing toys feat: Allow failing toys Mar 3, 2023
@matthewfeickert matthewfeickert marked this pull request as draft March 3, 2023 16:57
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (cb83590) 98.28% compared to head (803b842) 97.82%.

Files Patch % Lines
src/pyhf/infer/calculators.py 44.44% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
- Coverage   98.28%   97.82%   -0.46%     
==========================================
  Files          69       69              
  Lines        4539     4555      +16     
  Branches      803      807       +4     
==========================================
- Hits         4461     4456       -5     
- Misses         45       62      +17     
- Partials       33       37       +4     
Flag Coverage Δ
contrib 97.65% <44.44%> (-0.22%) ⬇️
doctest ?
unittests-3.10 96.09% <44.44%> (-0.21%) ⬇️
unittests-3.11 96.09% <44.44%> (-0.21%) ⬇️
unittests-3.8 96.11% <44.44%> (-0.21%) ⬇️
unittests-3.9 96.13% <44.44%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert added the API Changes the public API label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes the public API feat/enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Allow toys to fail
2 participants