Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use '--pytest-test-first' option for naming clarity #1892

Merged
merged 2 commits into from Jun 22, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 22, 2022

Description

Following pre-commit/pre-commit-hooks#779 and pre-commit-hooks v4.3.0 use the --pytest-test-first option of name-tests-test for clarity.

This amends PR #1877.

Related: scikit-hep/scikit-hep.github.io#231

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0 to get
`--pytest-test-first` option for name-test-tests.
* Use `--pytest-test-first` option for name-test-tests for greater clarity of
convention.
* Amends PR #1877.

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions chore Other changes that don't modify src or test files labels Jun 22, 2022
@matthewfeickert matthewfeickert added this to In progress in v0.7.0 via automation Jun 22, 2022
@matthewfeickert matthewfeickert self-assigned this Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1892 (474c7e3) into master (474c7e3) will not change coverage.
The diff coverage is n/a.

❗ Current head 474c7e3 differs from pull request most recent head aab274c. Consider uploading reports for the commit aab274c to get more accurate results

@@           Coverage Diff           @@
##           master    #1892   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4331     4331           
  Branches      730      730           
=======================================
  Hits         4252     4252           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.34% <0.00%> (ø)
doctest 60.63% <0.00%> (ø)
unittests-3.10 96.05% <0.00%> (ø)
unittests-3.7 96.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474c7e3...aab274c. Read the comment docs.

@matthewfeickert
Copy link
Member Author

As this is amending PR #1877, I'm going to approve and merge this myself given that it is already in when other maintainers were on holiday. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 2411ed3 into master Jun 22, 2022
@matthewfeickert matthewfeickert deleted the ci/change-pre-commit-alias branch June 22, 2022 23:59
v0.7.0 automation moved this from In progress to Done Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant