fix: Disallow Jinja2 v3.1.0 to avoid nbsphinx triggering attribute error #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratsg
approved these changes
Mar 24, 2022
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 68 68
Lines 4315 4315
Branches 725 725
=======================================
Hits 4236 4236
Misses 46 46
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
4 tasks
matthewfeickert
added a commit
that referenced
this pull request
Apr 3, 2022
* Revert PR #1824 to remove restrictions place on Jinja2 given spatialaudio/nbsphinx#641. The issues described there were resolved upstream of nbsphinx in jupyter/nbconvert#1737. - Lower bounds of 'nbconvert>=6.4.5' are not added as lower bound restrictions should be applied upstream of pyhf in nbsphinx. PR #1824 was applied only because it was necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stopgap measure to deal with Issue #1823 for the time being until there is a fix. As
nbsphinxv0.8.7is reliant onJinja2v3.0.XAPIs and soJinja2v3.1.0breaks it.This is a stopgap measure and this should be removed as soon as there is a resolution and new
nbsphinxrelease.c.f. spatialaudio/nbsphinx#641 for more details.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: