Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clipping asymptotics and incl pvalue for q-like test stats #1160

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: clipping asymptotics and incl pvalue for q-like test stats #1160

wants to merge 6 commits into from

Conversation

lukasheinrich
Copy link
Contributor

@lukasheinrich lukasheinrich commented Oct 29, 2020 •
edited by matthewfeickert

Description

resolves #1159

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* TBD

@lukasheinrich lukasheinrich changed the title clip & incl feat: clipping asymptotics and incl pvalue for q-like test stats Oct 29, 2020
@matthewfeickert matthewfeickert added contrib Targeting pyhf.contrib and not the core of pyhf feat/enhancement New feature or request visualization Related to plotting of results labels Oct 29, 2020
@lukasheinrich lukasheinrich mentioned this pull request Oct 29, 2020
Closed
@lukasheinrich lukasheinrich mentioned this pull request Nov 9, 2020
Closed
@kratsg
Copy link
Contributor

kratsg commented Feb 4, 2021

#993 seems to do the same thing.

@matthewfeickert
Copy link
Member

#993 seems to do the same thing.

Yeah, agreed. @lukasheinrich if there isn't further motivation for this PR beyond PR #993 then maybe this PR could be revised to just contribute the notebook instead.

@matthewfeickert matthewfeickert added this to In progress in v0.6.1 via automation Feb 9, 2021
@matthewfeickert matthewfeickert mentioned this pull request Feb 10, 2021
Merged
4 tasks
@matthewfeickert matthewfeickert removed this from In progress in v0.6.1 Mar 5, 2021
@matthewfeickert matthewfeickert added this to In progress in v0.6.2 via automation Mar 5, 2021
@matthewfeickert matthewfeickert added this to In progress in v0.6.3 via automation Jun 21, 2021
@matthewfeickert matthewfeickert removed this from In progress in v0.6.2 Jun 21, 2021
@matthewfeickert matthewfeickert removed this from In progress in v0.6.3 Aug 25, 2021
@matthewfeickert matthewfeickert added this to In progress in v0.6.4 via automation Aug 25, 2021
@matthewfeickert
Copy link
Member

In my mind as soon as this is done we should get v0.6.4 out and then move to working on features for v0.7.0.

@matthewfeickert matthewfeickert removed this from In progress in v0.6.4 Oct 22, 2021
@matthewfeickert matthewfeickert added this to In progress in v0.7.0 via automation Oct 22, 2021
@kratsg kratsg removed this from In progress in v0.7.0 Aug 30, 2022
@kratsg kratsg added this to In progress in v0.7.1 via automation Aug 30, 2022
@matthewfeickert matthewfeickert changed the base branch from master to main September 21, 2022 20:54
@matthewfeickert matthewfeickert removed this from In progress in v0.7.1 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukasheinrich lukasheinrich

Labels
contrib Targeting pyhf.contrib and not the core of pyhf feat/enhancement New feature or request visualization Related to plotting of results
Projects
pyhf v0.8.0
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support variations on CLs dealing w/ inclusive pvalue and clipping
3 participants
@lukasheinrich @kratsg @matthewfeickert