Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use black Jupyter hook for Jupyter notebooks over nbqa-black #1594

Closed
matthewfeickert opened this issue Sep 6, 2021 · 0 comments · Fixed by #1598
Closed

Use black Jupyter hook for Jupyter notebooks over nbqa-black #1594

matthewfeickert opened this issue Sep 6, 2021 · 0 comments · Fixed by #1598
Assignees
@matthewfeickert
Labels
CI CI systems, GitHub Actions good first issue Good for newcomers
Projects
v0.6.4

Comments

@matthewfeickert
Copy link
Member

Just FYI, black now has a Jupyter hook, I'd advise using that instead of nbqa-black (cc @matthewfeickert )

Originally posted by @MarcoGorelli in scikit-hep/hist#276 (comment)
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Sep 6, 2021
@matthewfeickert matthewfeickert added this to To do in v0.6.4 via automation Sep 6, 2021
@matthewfeickert matthewfeickert added the good first issue Good for newcomers label Sep 6, 2021
@matthewfeickert matthewfeickert changed the title Use black now has a Jupyter hook for Jpyter notebooks over nbqa-black Use black Jupyter hook for Jpyter notebooks over nbqa-black Sep 6, 2021
@matthewfeickert matthewfeickert changed the title Use black Jupyter hook for Jpyter notebooks over nbqa-black Use black Jupyter hook for Jupyter notebooks over nbqa-black Sep 6, 2021
@matthewfeickert matthewfeickert self-assigned this Sep 7, 2021
@matthewfeickert matthewfeickert mentioned this issue Sep 7, 2021
Merged
4 tasks
v0.6.4 automation moved this from To do to Done Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewfeickert matthewfeickert

Labels
CI CI systems, GitHub Actions good first issue Good for newcomers
Projects
No open projects
v0.6.4
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Use jupyter-black pre-commit hook over nbqa-black scikit-hep/pyhf
1 participant
@matthewfeickert