Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 as a new Windows platform #612

Merged
merged 1 commit into from Dec 9, 2021

Conversation

gaborkertesz-linaro
Copy link
Contributor

Enable new Windows platform for CMakeVisualStudioIDEGenerator.

Tested with CMake Python distribution wheel generation on win-arm64.

Enable new Windows platform for CMakeVisualStudioIDEGenerator and
call proper environment setting.
@gaborkertesz-linaro gaborkertesz-linaro changed the title Add ARM64 for CMakeGenerator Add ARM64 as a new Windows platform Dec 2, 2021
Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to take this as "experimental support for ARM" until we either get a Windows ARM box, or CI starts supporting it (which I've heard might be soon).

@gaborkertesz-linaro
Copy link
Contributor Author

I'd be happy to take this as "experimental support for ARM" until we either get a Windows ARM box, or CI starts supporting it (which I've heard might be soon).

Thanks, really appreciated! If I can do anything to make it more smooth, just please let me know!

@henryiii
Copy link
Contributor

henryiii commented Dec 8, 2021

We are all very busy with #601 (due today), but after that, unless there are objections, I'd say we should merge.

@henryiii
Copy link
Contributor

henryiii commented Dec 9, 2021

Should go along nicely with pypa/cibuildwheel#920 :)

@henryiii henryiii merged commit dad6363 into scikit-build:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants