Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-build does not work with setuptools>=64 in edit mode #740

Open
njzjz opened this issue Aug 17, 2022 · 6 comments
Open

scikit-build does not work with setuptools>=64 in edit mode #740

njzjz opened this issue Aug 17, 2022 · 6 comments

Comments

@njzjz
Copy link

njzjz commented Aug 17, 2022

In setuptools 63, when installing with pip install -v -e ., CMake will be executed.

In 64 and 65, using the same command, CMake won't be executed during installation.

@njzjz njzjz changed the title scikit-build does not work with pip 22.2 in edit mode scikit-build does not work with setuptools>=64 in edit mode Aug 17, 2022
@njzjz
Copy link
Author

njzjz commented Aug 17, 2022

A temporary solution is to set the environment variable:

export SETUPTOOLS_ENABLE_FEATURES="legacy-editable"

It looks like setuptools 64 changes the behavior of the editable mode.

@henryiii
Copy link
Contributor

Yes, this was seen by @kratsg shortly after 64 was released. That's a fine workaround until we figure out what needs to be done to support the new editable mode. I'll be more familiar with what needs to be done after working on scikit_build_core for a while, so probably will focus there unless someone comes along sooner to do it.

@casperdcl
Copy link

running into the same problem.

Arrived here via pypa/setuptools#3550 <- pypa/setuptools#3488 <- AMYPAD/CuVec#25

@abravalheri
Copy link

Just in case anyone is looking into this problem, the documentation for custom build was updated in the v64 release: https://setuptools.pypa.io/en/latest/userguide/extension.html. Hopefully this is useful.

@0x2b3bfa0
Copy link

0x2b3bfa0 commented Aug 21, 2022

Additional links for #740 (comment)

Footnotes

  1. Especially because of this change

casperdcl added a commit to AMYPAD/NumCu that referenced this issue Aug 21, 2022
- partially reverts cc4da20
- TODO: revert once scikit-build/scikit-build#740 is fixed
@henryiii
Copy link
Contributor

I believe this requires implementing get_output and get_output_mapping. This is something the current scikit-build can't produce, since it delegates the build to CMake, and has no idea about what is going in and out. scikit-build-core, however, does know this (via requiring CMake 3.15+ and using the File API introduced in 3.15), so I think this will have to wait until scikit-build-core is ready.

Unless I'm mistaken, but I think that's what is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@abravalheri @henryiii @njzjz @casperdcl @0x2b3bfa0 and others