Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable installation broken for pip>=21.3 #770

Closed
qnzhou opened this issue Oct 8, 2022 · 2 comments
Closed

Editable installation broken for pip>=21.3 #770

qnzhou opened this issue Oct 8, 2022 · 2 comments

Comments

@qnzhou
Copy link

qnzhou commented Oct 8, 2022

Tested with scikit-build-sample-projects.

Steps to reproduce:

$ pip install pip==21.3  # or any version >=21.3.
$ git clone git@github.com:scikit-build/scikit-build-sample-projects.git
$ cd scikit-build-sample-prjects/projects/hello-cmake-package
$ pip install -v -e .  # from the print out, it is apparent that cmake is never invoked by the build.
$ python -c "import hello"  # Result in "ModuleNotFoundError: No module named 'hello._hello'"

Rolling back pip to 21.2.4 results in the correct bahavior.

@henryiii
Copy link
Contributor

henryiii commented Oct 8, 2022

You can use SETUPTOOLS_ENABLE_FEATURES=legacy-editable for now. In order to support the new editable mode, we have to build a mapping of input to output files, which will only be possible with CMake 3.15+ as a requirement (and is being worked on in scikit-build-core, the rewrite). Dup of #740.

@qnzhou
Copy link
Author

qnzhou commented Oct 9, 2022

Thanks Henry! Closing this as it is duplicate of #740 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants