Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use wheel tags cli #84

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Oct 9, 2021

Try using pypa/wheel#422

@henryiii
Copy link
Contributor

I think this is now working on everyone except macOS, which currently breaks delocate due to wheel changes not related to this functionality. See pypa/wheel#433.

@henryiii henryiii force-pushed the test-wheel-cli branch 2 times, most recently from 747f724 to a54945c Compare March 14, 2023 20:00
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title Try wheel cli chore: use wheel tags cli Mar 14, 2023
@henryiii henryiii marked this pull request as ready for review March 14, 2023 21:14
@jcfr
Copy link
Contributor

jcfr commented Mar 15, 2023

Moving away from jcfr/wheeltools.git@wheeltools-2018-10-28-a2f174d0e and getting ride of the converted script is really nice 💯

I am glad the wheel cli now support updating the tags 🙏

Also neat to see our packages featured in the examples at https://wheel.readthedocs.io/en/stable/reference/wheel_tags.html#examples

Thanks again @henryiii for adding the tags interface to the wheel cli 💯 👌

@mayeut mayeut merged commit 1de6e50 into scikit-build:master Mar 15, 2023
@mayeut mayeut deleted the test-wheel-cli branch October 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants