Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CMake 3.18.4 #118

Merged
merged 2 commits into from Nov 11, 2020
Merged

Update to CMake 3.18.4 #118

merged 2 commits into from Nov 11, 2020

Conversation

AWSjswinney
Copy link
Contributor

  • Update to CMake 3.18.4
  • Remove redundant (and broken) aarch64 builds from CircleCI
  • Switch to using Travis-CI Graviton 2 builder instances which are much faster

I'm creating this PR selfishly in order to bump the cmake version so new wheels can be released to Pypi.org. This will fix the currently broken aarch64 wheel that is published there.

Arm builds are now down with Travis-CI instead, so it is not necessary
to use dockcross on CircleCI. Also switch to using the graviton2 based
arm64 builder instances on Travis-CI.
@vfazio
Copy link

vfazio commented Nov 11, 2020

@AWSjswinney thoughts on who we can ping to get this merged in? I know quite a few are waiting on this to land for opencv/opencv-python#366 to get resolved

@AWSjswinney
Copy link
Contributor Author

@thewtex Can you merge this to do another release soon? I'm not sure why Github thinks it's still waiting on TravisCI. It looks like it completed successfully to me.

@jcfr
Copy link
Contributor

jcfr commented Nov 11, 2020

Thanks for the reminder and for the patience 🙏

I'm not sure why Github thinks it's still waiting on TravisCI.

I just fixed this updating the requirements associated with master branch integration.

The requirement was incorrect following the transition from travis.org to travis.com

@jcfr jcfr merged commit 9f0eccb into scikit-build:master Nov 11, 2020
@jcfr
Copy link
Contributor

jcfr commented Nov 11, 2020

Tag has been pushed and release of corresponding wheels is in progress.

@AWSjswinney
Copy link
Contributor Author

It looks like the Linux/Arm64 deployment failed. I was afraid of this, since I did have a way to actually test the deployment. Can I fix it by just installing twine in the container?

@jcfr
Copy link
Contributor

jcfr commented Nov 11, 2020

it looks like the Linux/Arm64 deployment failed.

Indeed. For reference, see https://travis-ci.com/github/scikit-build/cmake-python-distributions/jobs/434064631

Can I fix it by just installing twine in the container?

Thanks for offering to help 🙏

Installing twine along with additional tweaks should do it.

I just pushed a Pull Request that should help, see #121

Let's see how this works out. In the meantime, would appreciate if you could also review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants