Make clearer the responsibilities of the head shared component #3229

sciety · May 8, 2024 · 6197fd0 · 6197fd0
1 parent 06f5b4a
commit 6197fd0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/read-side/html-pages/shared-components/head/dynamic-head-view-model.ts b/src/read-side/html-pages/shared-components/head/dynamic-head-view-model.ts
@@ -0,0 +1,6 @@
+import { ClientClassification } from './client-classification';
+import { HtmlPageHead } from '../../html-page';
+
+export type DynamicHeadViewModel = HtmlPageHead & {
+  clientClassification: ClientClassification,
+};
diff --git a/src/read-side/html-pages/shared-components/head/head.ts b/src/read-side/html-pages/shared-components/head/head.ts
@@ -2,14 +2,10 @@ import { htmlEscape } from 'escape-goat';
 import * as O from 'fp-ts/Option';
 import { pipe } from 'fp-ts/function';
 import { ClientClassification } from './client-classification';
+import { DynamicHeadViewModel } from './dynamic-head-view-model';
 import { fathom, googleTagManager } from '../../../../shared-components/analytics';
 import { HtmlFragment, toHtmlFragment } from '../../../../types/html-fragment';
 import { UserId } from '../../../../types/user-id';
-import { HtmlPageHead } from '../../html-page';
-
-export type DynamicHeadViewModel = HtmlPageHead & {
-  clientClassification: ClientClassification,
-};
 
 const renderWithClientClassification = (headTagContents: string, clientClassification: ClientClassification) => `
   <head data-user-agent="${htmlEscape(clientClassification.userAgent ?? '')}">

diff --git a/src/read-side/html-pages/shared-components/head/index.ts b/src/read-side/html-pages/shared-components/head/index.ts
@@ -1,2 +1,3 @@
-export { DynamicHeadViewModel, head } from './head';
 export { ClientClassification } from './client-classification';
+export { DynamicHeadViewModel } from './dynamic-head-view-model';
+export { head } from './head';