Extract a seam and attempt naming to improve clarity #3234

sciety · May 10, 2024 · 179a02d · 179a02d
1 parent 05ffab7
commit 179a02d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/ingest/evaluation-discovery/discover-evaluations-from-hypothesis-group.ts b/src/ingest/evaluation-discovery/discover-evaluations-from-hypothesis-group.ts
@@ -12,13 +12,19 @@ type Ports = {
   fetchData: FetchData,
 };
 
+const calculateEarliestPublicationDateToConsider = (earliestPublicationDateToConsider: Date | undefined): Date => (
+  earliestPublicationDateToConsider instanceof Date
+    ? earliestPublicationDateToConsider
+    : daysAgo(5)
+);
+
 export const discoverEvaluationsFromHypothesisGroup = (
   publisherGroupId: string,
-  earliestPublicationDateToConsider?: Date,
+  avoidWhenPublishedBefore?: Date,
 ): DiscoverPublishedEvaluations => (ports: Ports) => pipe(
   publisherGroupId,
   Hyp.fetchEvaluationsByGroupSince(
-    earliestPublicationDateToConsider instanceof Date ? earliestPublicationDateToConsider : daysAgo(5),
+    calculateEarliestPublicationDateToConsider(avoidWhenPublishedBefore),
     ports.fetchData,
   ),
   TE.map(RA.map(convertHypothesisAnnotationToEvaluation(tagToEvaluationTypeMap))),